giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Koontz" <ekoo...@hiro-tan.org>
Subject Re: Review Request: GIRAPH-262 Netty optimizations and bandwidth tracking
Date Tue, 07 Aug 2012 02:13:00 GMT


> On Aug. 6, 2012, 6:15 p.m., Eugene Koontz wrote:
> > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/NettyClient.java,
line 112
> > <https://reviews.apache.org/r/6008/diff/1/?file=123493#file123493line112>
> >
> >     For consistency with other pipeline components, use new ByteCounter() here.
> 
> Avery Ching wrote:
>     I need the reference here so that I can print the metrics periodically in the client.
 See NettyClient.java:237.

I see, makes sense, thanks.


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6008/#review9890
-----------------------------------------------------------


On Aug. 7, 2012, 1:04 a.m., Avery Ching wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6008/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 1:04 a.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> * Makes netty the default instead of HadoopRPC
> * Added optimization to handle requests locally when possible rather than go over the
network
> * Added TimedLogger to print only within a given time period
> * Added optimization for using multiple channels between clients/servers when bandwidth
is limited per connection
> * Added ByteCounter to track bandwidth across Netty (can be later integrated with GIRAPH-232).
> * Upgraded rat to 0.8 and excluded iml files (Intellij Idea)
> * Set 32 instead of 64 as the default maximum netty threads
> 
> 
> This addresses bug GIRAPH-262.
>     https://issues.apache.org/jira/browse/GIRAPH-262
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/giraph/trunk/pom.xml 1370086 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
1370086 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/ByteCounter.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/ChannelRotater.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/NettyClient.java
1370086 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/NettyServer.java
1370086 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/NettyWorkerClient.java
1370086 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/NettyWorkerClientServer.java
1370086 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/RequestDecoder.java
1370086 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/ResponseClientHandler.java
1370086 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/SendVertexRequest.java
1370086 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
1370086 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
1370086 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
1370086 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/utils/TimedLogger.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/giraph/comm/ConnectionTest.java
1370086 
> 
> Diff: https://reviews.apache.org/r/6008/diff/
> 
> 
> Testing
> -------
> 
> Passed mvn verify.  Used for the Hadoop Summit presentation results.
> 
> 
> Thanks,
> 
> Avery Ching
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message