giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-291) PredicateLock should have a constructor to take in a custom waiting time and additional testing
Date Wed, 08 Aug 2012 06:59:10 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430914#comment-13430914
] 

Avery Ching commented on GIRAPH-291:
------------------------------------

I agree that testing is good, but waitForever() should be simple.  

I did the "hack" you mentioned =), although in retrospect, I could have just done waitForever()
and then followed it up with a waitMsecs(0) to see if the predicate did in fact change.  That
would be good enough for the test.  I like getting rid of negative arguments in waitMsecs()
that you did in GIRAPH-246, hence using it here as well.

Anyway, I think this patch is good to go and shouldn't cause any contention.  This really
only simplifies the code and adds more testing.
                
> PredicateLock should have a constructor to take in a custom waiting time and additional
testing
> -----------------------------------------------------------------------------------------------
>
>                 Key: GIRAPH-291
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-291
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>         Attachments: GIRAPH-291.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message