giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-258) Check type compatibility before submitting job
Date Sat, 04 Aug 2012 00:49:02 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428510#comment-13428510
] 

Eli Reisman commented on GIRAPH-258:
------------------------------------

All of the code is copied over from the GiraphMapper impl where the generics were checked
after the job was already running, test code didn't change, just added the validator to it.
I will remove check style comments. Those were the pre-existing tests as well, and they work
so I left them alone. I can change the unchecked exceptions to fail() calls in the tests (that
never made any sense but I figured it was a separate issue) further (very reasonable) fixes
to the existing code I stole/moved might deserve its own JIRA.

Fixing now...
                
> Check type compatibility before submitting job
> ----------------------------------------------
>
>                 Key: GIRAPH-258
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-258
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-258-1.patch
>
>
> Currently if one submits a job with a vertex and inputformat types that are not compatible
the job only fails during runtime.  Since we know the types at submission time, we can check
this before submitting and fail then.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message