Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@giraph.apache.org
Received-SPF: pass (nike.apache.org: domain of initialcontext@gmail.com
 designates 209.85.214.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CC231E68.1A9B%alessandro@fb.com>
References: <CC231E68.1A9B%alessandro@fb.com>
Date: Thu, 12 Jul 2012 13:36:35 -0700
Message-ID: 
 <CAB0m3-FoCNT2ey+w+7dUQqvTLzbSd5AGz_kKjvYT4XTTNHUozg@mail.gmail.com>
Subject: Re: Using Review Board
From: Eli Reisman <initialcontext@gmail.com>
To: dev@giraph.apache.org
Content-Type: multipart/alternative; boundary=e89a8f50318a6e1ec504c4a7eb04

--e89a8f50318a6e1ec504c4a7eb04
Content-Type: text/plain; charset=ISO-8859-1

I use git so I'm not sure. I have heard IntelliJ is not good at generating
patches for Giraph, and even IntelliJ pros like Jakob do that part at the
command line.

were you trying to upload into the repo or just upload a diff file to the
JIRA page for 244?

On Wed, Jul 11, 2012 at 4:13 AM, Alessandro Presta <alessandro@fb.com>wrote:

> Hi all,
>
> I'm trying to create a review for GIRAPH-244, but I can't seem to
> successfully upload the diff.
>
> I get: The file "
> http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/giraph/graph/TestIntIntNullIntVertex.java"
> (revision 1360122) was not found in the repository
>
> I tried generating the patch from IntelliJ or directly with "svn diff >
> GIRAPH-244.patch" using svn 1.7.5.
> I made sure that the base revision number was the same as the repo (being
> shared among all Apache projects, it changes very frequently).
> I tried putting "trunk" as base dir, "giraph/trunk", the full URL to the
> repo and all possible substrings I can think of.
>
> Has anyone succeeded in adding a review lately?
>
> Alessandro
>

--e89a8f50318a6e1ec504c4a7eb04--