Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 895BBC90A for ; Fri, 6 Jul 2012 11:43:38 +0000 (UTC) Received: (qmail 92469 invoked by uid 500); 6 Jul 2012 11:43:38 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 92414 invoked by uid 500); 6 Jul 2012 11:43:37 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 92378 invoked by uid 500); 6 Jul 2012 11:43:36 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Received: (qmail 92349 invoked by uid 99); 6 Jul 2012 11:43:35 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jul 2012 11:43:35 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id C069D142822 for ; Fri, 6 Jul 2012 11:43:35 +0000 (UTC) Date: Fri, 6 Jul 2012 11:43:35 +0000 (UTC) From: "Gianmarco De Francisci Morales (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: <421500022.13670.1341575015789.JavaMail.jiratomcat@issues-vm> In-Reply-To: <858493296.3516.1341414274896.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (GIRAPH-235) SequenceFile output format (id-value only) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GIRAPH-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407915#comment-13407915 ] Gianmarco De Francisci Morales commented on GIRAPH-235: ------------------------------------------------------- Indeed, you are right. Here is how SequenceFileOutputFormat returns the RecordWriter. {code} 61 final SequenceFile.Writer out = 62 SequenceFile.createWriter(fs, conf, file, 63 context.getOutputKeyClass(), 64 context.getOutputValueClass(), 65 compressionType, 66 codec, 67 context); 68 69 return new RecordWriter() { 70 71 public void write(K key, V value) 72 throws IOException { 73 74 out.append(key, value); 75 } {code} It uses the key/value class information in the context and not the one in the template. I think I cannot configure the RecordWriter at runtime: information about generic types is stripped out from the class files. However, I am a bit confused. I would think that these lines in GraphMapper serve exactly the purpose of configuring the job correctly: {code} conf.setClass(GiraphJob.VERTEX_INDEX_CLASS, (Class) vertexIndexType, WritableComparable.class); conf.setClass(GiraphJob.VERTEX_VALUE_CLASS, (Class) vertexValueType, {code} Shouldn't it work out of the box this way? > SequenceFile output format (id-value only) > ------------------------------------------ > > Key: GIRAPH-235 > URL: https://issues.apache.org/jira/browse/GIRAPH-235 > Project: Giraph > Issue Type: New Feature > Components: lib > Reporter: Gianmarco De Francisci Morales > Attachments: GIRAPH-235.1.patch > > > Create a SequenceFileOutputFormat for the cases where compression is important and we only want the value of the vertex (e.g. pagerank) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira