Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 03E5FDAEC for ; Tue, 17 Jul 2012 07:35:20 +0000 (UTC) Received: (qmail 95237 invoked by uid 500); 17 Jul 2012 07:35:19 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 95184 invoked by uid 500); 17 Jul 2012 07:35:19 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Delivered-To: moderator for dev@giraph.apache.org Received: (qmail 92371 invoked by uid 500); 17 Jul 2012 07:33:55 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Content-Type: multipart/alternative; boundary="===============5458084313030838720==" MIME-Version: 1.0 Subject: Re: Review Request: GIRAPH-262 Netty optimizations and bandwidth tracking From: "Avery Ching" To: "Avery Ching" , "giraph" Date: Tue, 17 Jul 2012 07:33:54 -0000 Message-ID: <20120717073354.14836.38577@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Avery Ching" X-ReviewGroup: giraph X-ReviewRequest-URL: https://reviews.apache.org/r/6008/ X-Sender: "Avery Ching" References: <20120717073351.14836.23644@reviews.apache.org> In-Reply-To: <20120717073351.14836.23644@reviews.apache.org> Reply-To: "Avery Ching" --===============5458084313030838720== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6008/ ----------------------------------------------------------- (Updated July 17, 2012, 7:33 a.m.) Review request for giraph. Description ------- * Makes netty the default instead of HadoopRPC * Added optimization to handle requests locally when possible rather than g= o over the network * Added TimedLogger to print only within a given time period * Added optimization for using multiple channels between clients/servers wh= en bandwidth is limited per connection * Added ByteCounter to track bandwidth across Netty (can be later integrate= d with GIRAPH-232). * Upgraded rat to 0.8 and excluded iml files (Intellij Idea) * Set 32 instead of 64 as the default maximum netty threads This addresses bug GIRAPH-262. https://issues.apache.org/jira/browse/GIRAPH-262 Diffs ----- http://svn.apache.org/repos/asf/giraph/trunk/pom.xml 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/benchmark/PseudoRandomVertexInputFormat.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/comm/ByteCounter.java PRE-CREATION = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/comm/ChannelRotater.java PRE-CREATION = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/comm/NettyClient.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/comm/NettyServer.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/comm/NettyWorkerClient.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/comm/NettyWorkerClientServer.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/comm/NettyWorkerServer.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/comm/RequestDecoder.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/comm/ResponseClientHandler.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/comm/SendVertexRequest.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/graph/BspServiceWorker.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/graph/BspUtils.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/graph/GiraphJob.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/graph/GraphMapper.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/gir= aph/utils/TimedLogger.java PRE-CREATION = http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/gir= aph/comm/ConnectionTest.java 1362298 = http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/gir= aph/comm/RequestTest.java 1362298 = Diff: https://reviews.apache.org/r/6008/diff/ Testing ------- Passed mvn verify. Used for the Hadoop Summit presentation results. Thanks, Avery Ching --===============5458084313030838720==--