Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 02B85D67B for ; Fri, 27 Jul 2012 03:32:37 +0000 (UTC) Received: (qmail 4197 invoked by uid 500); 27 Jul 2012 03:32:37 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 4056 invoked by uid 500); 27 Jul 2012 03:32:36 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 4023 invoked by uid 500); 27 Jul 2012 03:32:35 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Received: (qmail 4000 invoked by uid 99); 27 Jul 2012 03:32:34 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jul 2012 03:32:34 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 9E528140B94 for ; Fri, 27 Jul 2012 03:32:34 +0000 (UTC) Date: Fri, 27 Jul 2012 03:32:33 +0000 (UTC) From: "Eli Reisman (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: <1301747895.109272.1343359954650.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1504168797.75821.1341088363987.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Updated] (GIRAPH-228) SimpleTriangleClosingVertex should not use ArrayWritable for a vertex value MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GIRAPH-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Reisman updated GIRAPH-228: ------------------------------- Attachment: GIRAPH-228-5.patch Had to un-stale this again after the vertex API redesign. Beefed up the tests a little bit, opted for the Guava collections over Java. passes mvn verify etc. > SimpleTriangleClosingVertex should not use ArrayWritable for a vertex value > --------------------------------------------------------------------------- > > Key: GIRAPH-228 > URL: https://issues.apache.org/jira/browse/GIRAPH-228 > Project: Giraph > Issue Type: Bug > Components: examples, test > Affects Versions: 0.2.0 > Reporter: Eli Reisman > Assignee: Eli Reisman > Priority: Trivial > Fix For: 0.2.0 > > Attachments: GIRAPH-228-1.patch, GIRAPH-228-2.patch, GIRAPH-228-4.patch, GIRAPH-228-5.patch > > > Need to convert to (yuck) Text output for vertex values, hope my tuples don't get too long. I followed several instructions from Hadoop about subclassing and using existing ArrayWritables, always both methods will compile with 'mvn verify' nicely, but break in actual use. GiraphJob.run() seems to be the culprit. Don't know if I can solve this myself in a way that will be pleasing to everyone. See GIRAPH-227 if you can help fix this ArrayWritable problem. As far as the vertex example, I'll covert it (and related tests) to Text output now. > Thanks again to Sean Choi, who noticed this and used the same (Text for tuples) solution successfully. ;) > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira