giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan van der Lugt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-233) Small errors found by FindBugs
Date Thu, 05 Jul 2012 18:06:33 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407338#comment-13407338
] 

Jan van der Lugt commented on GIRAPH-233:
-----------------------------------------

Added a fix to a small 'bug' in RequestRegistry in which finalize() is explicitly called.
finalize() should only be called by the garbage collector, from what I've understood, so I
renamed the method to shutdown().
                
> Small errors found by FindBugs
> ------------------------------
>
>                 Key: GIRAPH-233
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-233
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Jan van der Lugt
>            Assignee: Jan van der Lugt
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-233.patch, GIRAPH-233.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I ran FindBugs on the Giraph codebase and found some small peculiarities that can be
fixed easily. Some of them are just making some fields or inner classes static, but there
was also a case of an inputstream not being closed. These issues seem to minor to deserve
a JIRA each, so here they are, combined into one JIRA. It passes mvn verify.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message