giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan van der Lugt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-259) TestBspBasic.testBspPageRank is broken
Date Tue, 17 Jul 2012 02:49:34 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415852#comment-13415852
] 

Jan van der Lugt commented on GIRAPH-259:
-----------------------------------------

That will be my bad. The problem is the master does not execute workercontext functions, where
the aggregators are usually being reset. Thus, the master keeps on aggregating and never resets
the values unless you explicitly specify this. We could change the semantics to have all aggregators
being cleared by the default master.compute implementation at the beginning of each superstep,
so that the workercontext does not have to do this anymore.

Actually, I oppose the whole idea of the workercontext containing anything but performance/memory
optimizations (such as parsed strings or shared objects), it's much easier to do all the aggregator
processing in the master, since they are being collected there anyways.
                
> TestBspBasic.testBspPageRank is broken
> --------------------------------------
>
>                 Key: GIRAPH-259
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-259
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>
> Test crashes on line 152 in class SimplePageRankVertex in distributed mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message