giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman" <initialcont...@gmail.com>
Subject Review Request: makes maven -P option select the proper Profile to build, and resulting .tar.gz and .jar artifacts include label of which Hadoop version they are compatible with
Date Tue, 17 Jul 2012 02:40:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6001/
-----------------------------------------------------------

Review request for giraph.


Description
-------

makes -P profiles build properly (the maven repo fills up with new profile-related jars when
I run it, so I know its working) and the resulting artifacts have this appended in the name
"for-hadoop-XXX" where XXX is the version # of Hadoop compatible with that profile (according
to the POM.XML where profiles are defined.)


Diffs
-----


Diff: https://reviews.apache.org/r/6001/diff/


Testing
-------

When most recent patch was submitted (july 11, 2012). Tests with various -P maven options,
with this fix -Dhadoop=... does not seem to affect which profile is chosen any more (I moved
this job to <forHadoop> property, and moved the default setting for this to the default
profile markup and out of the global properties section, which seemed to allow a cleaner solution)


Thanks,

Eli Reisman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message