giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta" <alessan...@fb.com>
Subject Re: Review Request: Server-side combiner
Date Mon, 16 Jul 2012 19:31:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5986/
-----------------------------------------------------------

(Updated July 16, 2012, 7:31 p.m.)


Review request for giraph and Avery Ching.


Changes
-------

Moved combiner instance to ServerData


Description
-------

Uses the combiner for incoming messages on the server.


This addresses bug GIRAPH-224.
    https://issues.apache.org/jira/browse/GIRAPH-224


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/NettyWorkerServer.java
1362205 
  http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/SendPartitionMessagesRequest.java
1362205 
  http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/ServerData.java
1362205 
  http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/giraph/comm/ConnectionTest.java
1362205 
  http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/giraph/comm/RequestTest.java
1362205 

Diff: https://reviews.apache.org/r/5986/diff/


Testing
-------

mvn verify


Thanks,

Alessandro Presta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message