giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-259) TestBspBasic.testBspPageRank is broken
Date Tue, 24 Jul 2012 11:37:34 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421334#comment-13421334
] 

Maja Kabiljo commented on GIRAPH-259:
-------------------------------------

Jan, I'm not sure I follow, since master.compute is the place where user can implement what
he wants, and aggregators should be managed independently from that.

I started solving this on the way I mentioned, by exposing only getValue and aggregate methods,
and I want to confirm two things before proceeding:

1. This way we won't be able to deal directly with primitive types anymore (right now many
aggregators have methods for aggregating primitive types)

2. For persistent aggregators, we could only allow this option to be registered on master,
since on the workers they are going to be treated in the same way anyways. Otherwise we would
have to deal with cases when some workers registered aggregator as persistent and some as
temporary, and also we would have to send the information about persistence along with aggregator
values. Or we could really allow aggregator values to be persistent on some and temporary
on other workers, but I don't really see the use case for it.
                
> TestBspBasic.testBspPageRank is broken
> --------------------------------------
>
>                 Key: GIRAPH-259
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-259
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>
> Test crashes on line 152 in class SimplePageRankVertex in distributed mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message