giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maja Kabiljo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-245) BasicRPCCommunications fails with custom vertices
Date Tue, 10 Jul 2012 13:06:35 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410320#comment-13410320
] 

Maja Kabiljo commented on GIRAPH-245:
-------------------------------------

That piece of code only gets executed if there is a mutation, or if we receive a message for
a vertexId which doesn't exist. None of these should happen if vertices are not mutable. But
maybe we could add an informative message instead of crashing.

On a related note, in prepareSuperstep in NettyWorkerServer we will throw an IllegalStateException
if we have a mutation to add a vertex and we received messages for that vertex (line 119).
Is that a desired behavior?
                
> BasicRPCCommunications fails with custom vertices
> -------------------------------------------------
>
>                 Key: GIRAPH-245
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-245
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Sebastian Schelter
>
> BasicRPCCommunications assumes that every vertex is an instance of MutableVertex in line
1265:
> {noformat} 
>       if (vertex != null) {
>         ((MutableVertex<I, V, E, M>) vertex).setVertexId(vertexIndex);
>         partition.putVertex(vertex);
>       }
> {noformat} 
> For custom vertices that only extend BasicVertex, this code fails with a ClassCastException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message