giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-240) Our vertices shouldn't accept null ids or values
Date Mon, 09 Jul 2012 16:25:34 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409609#comment-13409609
] 

Alessandro Presta commented on GIRAPH-240:
------------------------------------------

Eli, you're reading my mind: today I've been working on a vertex redesign that is meant to
address most of the issues we've been raising lately.
The tests are passing and I only need to fix the documentation, then I'll submit it and you
all can have a look.

The changes go towards:
- making the API more intuitive
- fixing some sub-optimal solutions
- providing default implementations wherever they apply, so we avoid code duplication and
focus on real ad-hoc optimizations
- general cleanup

                
> Our vertices shouldn't accept null ids or values
> ------------------------------------------------
>
>                 Key: GIRAPH-240
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-240
>             Project: Giraph
>          Issue Type: Bug
>          Components: graph
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>
> I may be missing something, but I don't understand why HashMapVertex and EdgeListVertex
(and possibly others) check for null vertexId and vertexValue instead of complaining.
> Shouldn't each vertex be forced to have an id and a value? It's a source of potential
bugs (see the serialization code that has to check for null and read/write a boolean flag)
and I don't see the logic.
> If one doesn't want vertex/edge values at all there's always NullWritable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message