giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Reisman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-228) SimpleTriangleClosingVertex should not use ArrayWritable for a vertex value
Date Fri, 27 Jul 2012 18:03:33 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424022#comment-13424022
] 

Eli Reisman commented on GIRAPH-228:
------------------------------------

In case anyone noticed, one of the reasons I keep updating this is that the original SimpleTriangleClosingVertex
in GIRAPH-217 that was committed accidentally included a unit test completely commented out.
So besides that this is a more robust solution and can act as an example of a tuple Writable
in an application (missing from our current example vertices) it also runs all its tests.
So thats probably a bonus.
 
                
> SimpleTriangleClosingVertex should not use ArrayWritable for a vertex value
> ---------------------------------------------------------------------------
>
>                 Key: GIRAPH-228
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-228
>             Project: Giraph
>          Issue Type: Bug
>          Components: examples, test
>    Affects Versions: 0.2.0
>            Reporter: Eli Reisman
>            Assignee: Eli Reisman
>            Priority: Trivial
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-228-1.patch, GIRAPH-228-2.patch, GIRAPH-228-4.patch, GIRAPH-228-5.patch
>
>
> Need to convert to (yuck) Text output for vertex values, hope my tuples don't get too
long. I followed several instructions from Hadoop about subclassing and using existing ArrayWritables,
always both methods will compile with 'mvn verify' nicely, but break in actual use. GiraphJob.run()
seems to be the culprit. Don't know if I can solve this myself in a way that will be pleasing
to everyone. See GIRAPH-227 if you can help fix this ArrayWritable problem. As far as the
vertex example, I'll covert it (and related tests) to Text output now.
> Thanks again to Sean Choi, who noticed this and used the same (Text for tuples) solution
successfully. ;)
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message