Return-Path: X-Original-To: apmail-giraph-dev-archive@www.apache.org Delivered-To: apmail-giraph-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37ADBDBCA for ; Fri, 29 Jun 2012 01:55:45 +0000 (UTC) Received: (qmail 90841 invoked by uid 500); 29 Jun 2012 01:55:45 -0000 Delivered-To: apmail-giraph-dev-archive@giraph.apache.org Received: (qmail 90759 invoked by uid 500); 29 Jun 2012 01:55:44 -0000 Mailing-List: contact dev-help@giraph.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@giraph.apache.org Delivered-To: mailing list dev@giraph.apache.org Received: (qmail 90619 invoked by uid 500); 29 Jun 2012 01:55:44 -0000 Delivered-To: apmail-incubator-giraph-dev@incubator.apache.org Received: (qmail 90614 invoked by uid 99); 29 Jun 2012 01:55:44 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jun 2012 01:55:44 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 1A56B142850 for ; Fri, 29 Jun 2012 01:55:44 +0000 (UTC) Date: Fri, 29 Jun 2012 01:55:44 +0000 (UTC) From: "Eli Reisman (JIRA)" To: giraph-dev@incubator.apache.org Message-ID: <501161203.70146.1340934944109.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1645660514.3203.1339435304093.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Reopened] (GIRAPH-205) Move Giraph jar to root level of tar.gz MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GIRAPH-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Reisman reopened GIRAPH-205: -------------------------------- > Move Giraph jar to root level of tar.gz > --------------------------------------- > > Key: GIRAPH-205 > URL: https://issues.apache.org/jira/browse/GIRAPH-205 > Project: Giraph > Issue Type: Bug > Components: conf and scripts > Affects Versions: 0.2.0 > Reporter: Roman Shaposhnik > Assignee: Eli Reisman > Fix For: 0.2.0 > > Attachments: GIRAPH-205-fix.patch, GIRAPH-205.patch.txt > > > I see the following bit of code in bin/giraph: > {noformat} > for f in $GIRAPH_HOME/lib/giraph*.jar ; do > if [ -e "$f" ]; then > JAR=$f > break > fi > done > {noformat} > I find it puzzling that it doesn't look for $GIRAPH_HOME/giraph*.jar > In fact, I find it puzzling that it looks under lib at all, since my assumption is that lib is supposed to hold the dependencies only. > Either way, I suggest that we modify it to be: > {noformat} > for f in $GIRAPH_HOME/lib/giraph*.jar $GIRAPH_HOME/giraph*.jar ; do > if [ -e "$f" ]; then > JAR=$f > break > fi > done > {noformat} > Thoughts? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira