giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan van der Lugt <janl...@gmail.com>
Subject Re: NullWritable as VertexData, EdgeData or MessageData
Date Thu, 28 Jun 2012 01:04:01 GMT
Ah, ok. I did include a patch, but I'll remember to use 'submit patch'.
Thanks!

On Wed, Jun 27, 2012 at 5:31 PM, Jakob Homan <jghoman@gmail.com> wrote:

> Sure thing.  Just as an FYI for our new contributors, I try to do
> patch reviews every day, but because there are so many patches in
> various stages of development, I only review those marked as "Patch
> Available."  This status informs committers the submitter things the
> patch is ready to be reviewed and is eligible for committing.  If a
> patch is not in this state, it'll likely get ignored.
>
> The annoying thing is is that to mark it patch available, one clicks
> "submit patch," which is not the most intuitively named button...
>
>
> On Wed, Jun 27, 2012 at 5:00 PM, Jan van der Lugt <janlugt@gmail.com>
> wrote:
> > Hi all,
> >
> > Right now it is not possible to use NullWritable as VertexData, EdgeData
> or
> > MessageData. I made a small patch to enable this, since it can save a lot
> > of memory (especially in the case of EdgeData). Could someone take a look
> > at this JIRA: https://issues.apache.org/jira/browse/GIRAPH-216 ? There
> are
> > only a few lines of added code in the patch, which catches the
> NullWritable
> > type and returns the singleton NullWritable instead of instantiating a
> new
> > NullWritable (which is not possible). Thanks!
> >
> > - Jan
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message