giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (GIRAPH-205) Move Giraph jar to root level of tar.gz
Date Fri, 29 Jun 2012 19:03:43 GMT

     [ https://issues.apache.org/jira/browse/GIRAPH-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jakob Homan resolved GIRAPH-205.
--------------------------------

    Resolution: Fixed
    
> Move Giraph jar to root level of tar.gz
> ---------------------------------------
>
>                 Key: GIRAPH-205
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-205
>             Project: Giraph
>          Issue Type: Bug
>          Components: conf and scripts
>    Affects Versions: 0.2.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-205-fix.patch, GIRAPH-205.patch.txt
>
>
> I see the following bit of code in bin/giraph:
> {noformat}
>         for f in $GIRAPH_HOME/lib/giraph*.jar ; do
>           if [ -e "$f" ]; then
>             JAR=$f
>             break
>           fi
>         done
> {noformat}
> I find it puzzling that it doesn't look for $GIRAPH_HOME/giraph*.jar 
> In fact, I find it puzzling that it looks under lib at all, since my assumption is that
lib is supposed to hold the dependencies only.
> Either way, I suggest that we modify it to be:
> {noformat}
>         for f in $GIRAPH_HOME/lib/giraph*.jar $GIRAPH_HOME/giraph*.jar  ; do
>           if [ -e "$f" ]; then
>             JAR=$f
>             break
>           fi
>         done
> {noformat}
> Thoughts?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message