giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan van der Lugt (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-192) Move aggregators to a seperate sub-package
Date Tue, 19 Jun 2012 19:38:43 GMT


Jan van der Lugt commented on GIRAPH-192:

Yes, Java's type system and Hadoop's Writables are not playing nice together. I've changed
several things:
- deleted the old aggregators (was not included in previous patch)
- added unit tests. not really sure if this is ok, haven't written a lot of unit tests before
- boolean and / or aggregators had the opposite operators in them
- product aggregators start with a default value of 1 (found this bug with the unit tests,
- fixed checkstyle warnings

Don't know how we would test the overflow behavior in a unit test, do you have ideas for this,
> Move aggregators to a seperate sub-package
> ------------------------------------------
>                 Key: GIRAPH-192
>                 URL:
>             Project: Giraph
>          Issue Type: Improvement
>          Components: examples
>    Affects Versions: 0.2.0
>            Reporter: Jan van der Lugt
>            Assignee: Jan van der Lugt
>            Priority: Minor
>             Fix For: 0.2.0
>         Attachments: GIRAPH-192.patch, GIRAPH-192.patch
>   Original Estimate: 2h
>  Remaining Estimate: 2h
> Since aggregators will be re-used throughout many projects and algorithms, it makes sense
to implement the most common ones in a separate sub-package. This will reduce the time required
for users when they implement their projects based on Giraph, because the required aggregators
are already in place. I implemented the following ones:
> for int/long/float/double: min, max, product, sum, overwrite
> for boolean: and, or, overwrite
> Most of them speak for themselves, except for the overwrite one. This aggregator simply
overwrites the stored value when a new value is aggregated. This is useful when one node is
in some way a master node (for example a source node in an routing algorithm), and this node
wants to broadcast a value to all other nodes.
> Attached is a patch against trunk implementing the aggregators and patching some existing
files so they use the .aggregators package instead of the .examples one.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message