giraph-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apre...@apache.org
Subject git commit: updated refs/heads/trunk to b88292d
Date Mon, 06 May 2013 20:22:40 GMT
Updated Branches:
  refs/heads/trunk 61ef4d2bc -> b88292dbf


GIRAPH-657: Remove unused reuseIncomingEdgeObjects option.


Project: http://git-wip-us.apache.org/repos/asf/giraph/repo
Commit: http://git-wip-us.apache.org/repos/asf/giraph/commit/b88292db
Tree: http://git-wip-us.apache.org/repos/asf/giraph/tree/b88292db
Diff: http://git-wip-us.apache.org/repos/asf/giraph/diff/b88292db

Branch: refs/heads/trunk
Commit: b88292dbffea2fdc03abc68685394b64d4f34cba
Parents: 61ef4d2
Author: Alessandro Presta <alessandro@fb.com>
Authored: Mon May 6 12:06:56 2013 -0700
Committer: Alessandro Presta <alessandro@fb.com>
Committed: Mon May 6 13:22:26 2013 -0700

----------------------------------------------------------------------
 CHANGELOG                                          |    2 ++
 .../apache/giraph/conf/GiraphConfiguration.java    |    9 ---------
 .../org/apache/giraph/conf/GiraphConstants.java    |    9 ---------
 3 files changed, 2 insertions(+), 18 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/giraph/blob/b88292db/CHANGELOG
----------------------------------------------------------------------
diff --git a/CHANGELOG b/CHANGELOG
index 6439581..8a2b9eb 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,6 +1,8 @@
 Giraph Change Log
 
 Release 1.0.1 - unreleased
+  GIRAPH-657: Remove unused reuseIncomingEdgeObjects option (apresta)
+
   GIRAPH-592: YourKit profiler (nitay)
 
   GIRAPH-618: Website Documentation: Aggregators (and sharded aggregators)

http://git-wip-us.apache.org/repos/asf/giraph/blob/b88292db/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
----------------------------------------------------------------------
diff --git a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
index 48f3d4b..8d74626 100644
--- a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
+++ b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java
@@ -901,15 +901,6 @@ public class GiraphConfiguration extends Configuration
   }
 
   /**
-   * Check if we can reuse incoming edge objects.
-   *
-   * @return True iff we can reuse incoming edge objects.
-   */
-  public boolean reuseIncomingEdgeObjects() {
-    return GiraphConstants.REUSE_INCOMING_EDGE_OBJECTS.get(this);
-  }
-
-  /**
    * Get the local hostname on the given interface.
    *
    * @return The local hostname

http://git-wip-us.apache.org/repos/asf/giraph/blob/b88292db/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
----------------------------------------------------------------------
diff --git a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
index 0067c25..54a40b7 100644
--- a/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
+++ b/giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
@@ -421,15 +421,6 @@ public interface GiraphConstants {
       new IntConfOption("giraph.maxMutationsPerRequest", 100);
 
   /**
-   * Whether we should reuse the same Edge object when adding edges from
-   * requests.
-   * This works with edge storage implementations that don't keep references
-   * to the input Edge objects (e.g., ByteArrayVertex).
-   */
-  BooleanConfOption REUSE_INCOMING_EDGE_OBJECTS =
-      new BooleanConfOption("giraph.reuseIncomingEdgeObjects", false);
-
-  /**
    * Use message size encoding (typically better for complex objects,
    * not meant for primitive wrapped messages)
    */


Mime
View raw message