giraph-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ach...@apache.org
Subject svn commit: r1362726 - in /giraph/trunk: CHANGELOG findbugs-exclude.xml pom.xml
Date Wed, 18 Jul 2012 00:21:10 GMT
Author: aching
Date: Wed Jul 18 00:21:09 2012
New Revision: 1362726

URL: http://svn.apache.org/viewvc?rev=1362726&view=rev
Log:
GIRAPH-236: Add FindBugs to maven build (Jan van der Lugt via aching).


Added:
    giraph/trunk/findbugs-exclude.xml
Modified:
    giraph/trunk/CHANGELOG
    giraph/trunk/pom.xml

Modified: giraph/trunk/CHANGELOG
URL: http://svn.apache.org/viewvc/giraph/trunk/CHANGELOG?rev=1362726&r1=1362725&r2=1362726&view=diff
==============================================================================
--- giraph/trunk/CHANGELOG (original)
+++ giraph/trunk/CHANGELOG Wed Jul 18 00:21:09 2012
@@ -2,6 +2,9 @@ Giraph Change Log
 
 Release 0.2.0 - unreleased
 
+  GIRAPH-236: Add FindBugs to maven build (Jan van der Lugt via
+  aching).
+
   GIRAPH-224: Netty server-side combiner (apresta via aching).
 
   GIRAPH-251: Allow to access the distributed cache from Vertexes and

Added: giraph/trunk/findbugs-exclude.xml
URL: http://svn.apache.org/viewvc/giraph/trunk/findbugs-exclude.xml?rev=1362726&view=auto
==============================================================================
--- giraph/trunk/findbugs-exclude.xml (added)
+++ giraph/trunk/findbugs-exclude.xml Wed Jul 18 00:21:09 2012
@@ -0,0 +1,63 @@
+<?xml version="1.0"?>
+
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+-->
+
+<FindBugsFilter>
+  <Match>
+    <Bug pattern="DM_DEFAULT_ENCODING"/>
+  </Match>
+  <Match>
+    <Bug pattern="DM_EXIT"/>
+  </Match>
+  <Match>
+    <Bug pattern="EI_EXPOSE_REP"/>
+  </Match>
+  <Match>
+    <Bug pattern="EI_EXPOSE_REP2"/>
+  </Match>
+  <Match>
+    <Bug pattern="EQ_COMPARETO_USE_OBJECT_EQUALS"/>
+  </Match>
+  <Match>
+    <Bug pattern="JLM_JSR166_UTILCONCURRENT_MONITORENTER"/>
+  </Match>
+  <Match>
+    <Bug pattern="NS_DANGEROUS_NON_SHORT_CIRCUIT"/>
+  </Match>
+  <Match>
+    <Bug pattern="RV_ABSOLUTE_VALUE_OF_HASHCODE"/>
+  </Match>
+  <Match>
+    <Bug pattern="RV_ABSOLUTE_VALUE_OF_RANDOM_INT"/>
+  </Match>
+  <Match>
+    <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
+  </Match>
+  <Match>
+    <Bug pattern="SE_COMPARATOR_SHOULD_BE_SERIALIZABLE"/>
+  </Match>
+  <Match>
+    <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
+  </Match>
+  <Match>
+    <Bug pattern="UUF_UNUSED_FIELD"/>
+  </Match>
+  <Match>
+    <Bug pattern="UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD"/>
+  </Match>
+</FindBugsFilter>

Modified: giraph/trunk/pom.xml
URL: http://svn.apache.org/viewvc/giraph/trunk/pom.xml?rev=1362726&r1=1362725&r2=1362726&view=diff
==============================================================================
--- giraph/trunk/pom.xml (original)
+++ giraph/trunk/pom.xml Wed Jul 18 00:21:09 2012
@@ -183,8 +183,8 @@ under the License.
           <configLocation>checkstyle.xml</configLocation>
           <enableRulesSummary>false</enableRulesSummary>
           <headerLocation>license-header.txt</headerLocation>
-	      <failOnError>true</failOnError>
-	      <includeTestSourceDirectory>false</includeTestSourceDirectory>
+          <failOnError>true</failOnError>
+          <includeTestSourceDirectory>false</includeTestSourceDirectory>
         </configuration>
         <executions>
           <execution>
@@ -317,131 +317,146 @@ under the License.
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>findbugs-maven-plugin</artifactId>
-        <version>2.3.2</version>
+        <version>2.5.1</version>
+        <configuration>
+          <xmlOutput>true</xmlOutput>
+          <findbugsXmlOutput>false</findbugsXmlOutput>
+          <excludeFilterFile>findbugs-exclude.xml</excludeFilterFile>
+        </configuration>
+        <executions>
+          <execution>
+            <phase>verify</phase>
+            <goals>
+              <goal>check</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-site-plugin</artifactId>
+        <version>3.0</version>
+        <configuration>
+          <reportPlugins>
+            <plugin>
+              <groupId>org.apache.maven.plugins</groupId>
+              <artifactId>maven-project-info-reports-plugin</artifactId>
+              <version>2.2</version>
+              <reports>
+                <report>index</report>
+                <report>project-team</report>
+                <report>license</report>
+                <report>mailing-list</report>
+                <report>dependencies</report>
+                <report>dependency-convergence</report>
+                <report>plugin-management</report>
+                <report>cim</report>
+                <report>issue-tracking</report>
+                <report>scm</report>
+                <report>summary</report>
+              </reports>
+            </plugin>
+            <plugin>
+              <groupId>org.apache.maven.plugins</groupId>
+              <artifactId>maven-surefire-report-plugin</artifactId>
+              <version>2.6</version>
+            </plugin>
+            <plugin>
+              <groupId>org.apache.maven.plugins</groupId>
+              <artifactId>maven-javadoc-plugin</artifactId>
+              <version>2.7</version>
+            </plugin>
+            <plugin>
+              <groupId>org.apache.maven.plugins</groupId>
+              <artifactId>maven-checkstyle-plugin</artifactId>
+              <version>2.9</version>
+            </plugin>
+            <plugin>
+              <groupId>org.codehaus.mojo</groupId>
+              <artifactId>jdepend-maven-plugin</artifactId>
+              <version>2.0-beta-2</version>
+            </plugin>
+            <plugin>
+              <groupId>org.codehaus.mojo</groupId>
+              <artifactId>cobertura-maven-plugin</artifactId>
+              <version>2.4</version>
+            </plugin>
+            <plugin>
+              <groupId>org.codehaus.mojo</groupId>
+              <artifactId>taglist-maven-plugin</artifactId>
+              <version>2.4</version>
+            </plugin>
+            <plugin>
+              <groupId>org.apache.maven.plugins</groupId>
+              <artifactId>maven-jxr-plugin</artifactId>
+              <version>2.1</version>
+            </plugin>
+            <plugin>
+              <groupId>org.codehaus.mojo</groupId>
+              <artifactId>findbugs-maven-plugin</artifactId>
+              <version>2.5.1</version>
+            </plugin>
+         </reportPlugins>
+        </configuration>
+      </plugin>
+      <plugin>
+        <groupId>org.apache.rat</groupId>
+        <artifactId>apache-rat-plugin</artifactId>
+        <version>0.7</version>
+        <executions>
+          <execution>
+            <phase>verify</phase>
+            <goals>
+              <goal>check</goal>
+            </goals>
+          </execution>
+        </executions>
+        <configuration>
+           <excludeSubProjects>false</excludeSubProjects>
+           <numUnapprovedLicenses>0</numUnapprovedLicenses>
+           <excludes>
+              <exclude>CODE_CONVENTIONS</exclude>
+              <!-- generated content -->
+              <exclude>**/target/**</exclude>
+              <exclude>_bsp/**</exclude>
+              <exclude>.checkstyle</exclude>
+              <!-- source control and IDEs -->
+              <exclude>.git/**</exclude>
+              <exclude>.gitignore</exclude>
+              <exclude>.idea/**</exclude>
+              <exclude>*.patch</exclude>
+           </excludes>
+        </configuration>
       </plugin>
-    <plugin>
-      <groupId>org.apache.maven.plugins</groupId>
-      <artifactId>maven-site-plugin</artifactId>
-      <version>3.0</version>
-      <configuration>
-        <reportPlugins>
-          <plugin>
-            <groupId>org.apache.maven.plugins</groupId>
-            <artifactId>maven-project-info-reports-plugin</artifactId>
-            <version>2.2</version>
-            <reports>
-              <report>index</report>
-              <report>project-team</report>
-              <report>license</report>
-              <report>mailing-list</report>
-              <report>dependencies</report>
-              <report>dependency-convergence</report>
-              <report>plugin-management</report>
-              <report>cim</report>
-              <report>issue-tracking</report>
-              <report>scm</report>
-              <report>summary</report>
-            </reports>
-          </plugin>
-          <plugin>
-            <groupId>org.apache.maven.plugins</groupId>
-            <artifactId>maven-surefire-report-plugin</artifactId>
-            <version>2.6</version>
-          </plugin>
-          <plugin>
-            <groupId>org.apache.maven.plugins</groupId>
-            <artifactId>maven-javadoc-plugin</artifactId>
-            <version>2.7</version>
-          </plugin>
-          <plugin>
-            <groupId>org.apache.maven.plugins</groupId>
-            <artifactId>maven-checkstyle-plugin</artifactId>
-            <version>2.9</version>
-          </plugin>
-          <plugin>
-            <groupId>org.codehaus.mojo</groupId>
-            <artifactId>jdepend-maven-plugin</artifactId>
-            <version>2.0-beta-2</version>
-          </plugin>
-          <plugin>
-            <groupId>org.codehaus.mojo</groupId>
-            <artifactId>cobertura-maven-plugin</artifactId>
-            <version>2.4</version>
-          </plugin>
-          <plugin>
-            <groupId>org.codehaus.mojo</groupId>
-            <artifactId>taglist-maven-plugin</artifactId>
-            <version>2.4</version>
-          </plugin>
-          <plugin>
-            <groupId>org.apache.maven.plugins</groupId>
-            <artifactId>maven-jxr-plugin</artifactId>
-            <version>2.1</version>
-          </plugin>
-       </reportPlugins>
-      </configuration>
-    </plugin>
-    <plugin>
-      <groupId>org.apache.rat</groupId>
-      <artifactId>apache-rat-plugin</artifactId>
-      <version>0.7</version>
-      <executions>
-        <execution>
-          <phase>verify</phase>
-          <goals>
-            <goal>check</goal>
-          </goals>
-        </execution>
-      </executions>
-      <configuration>
-         <excludeSubProjects>false</excludeSubProjects>
-         <numUnapprovedLicenses>0</numUnapprovedLicenses>
-         <excludes>
-            <exclude>CODE_CONVENTIONS</exclude>
-            <!-- generated content -->
-            <exclude>**/target/**</exclude>
-            <exclude>_bsp/**</exclude>
-            <exclude>.checkstyle</exclude>
-            <!-- source control and IDEs -->
-            <exclude>.git/**</exclude>
-            <exclude>.idea/**</exclude>
-            <exclude>*.patch</exclude>
-         </excludes>
-      </configuration>
-    </plugin>
     </plugins>
     <pluginManagement>
-    	<plugins>
-    		<!--This plugin's configuration is used to store Eclipse m2e settings only. It has
no influence on the Maven build itself.-->
-    		<plugin>
-    			<groupId>org.eclipse.m2e</groupId>
-    			<artifactId>lifecycle-mapping</artifactId>
-    			<version>1.0.0</version>
-    			<configuration>
-    				<lifecycleMappingMetadata>
-    					<pluginExecutions>
-    						<pluginExecution>
-    							<pluginExecutionFilter>
-    								<groupId>
-    									org.apache.maven.plugins
-    								</groupId>
-    								<artifactId>
-    									maven-assembly-plugin
-    								</artifactId>
-    								<versionRange>[2.2,)</versionRange>
-    								<goals>
-    									<goal>single</goal>
-    								</goals>
-    							</pluginExecutionFilter>
-    							<action>
-    								<ignore></ignore>
-    							</action>
-    						</pluginExecution>
-    					</pluginExecutions>
-    				</lifecycleMappingMetadata>
-    			</configuration>
-    		</plugin>
-    	</plugins>
+      <plugins>
+        <!--This plugin's configuration is used to store Eclipse m2e settings only. It
has no influence on the Maven build itself.-->
+        <plugin>
+          <groupId>org.eclipse.m2e</groupId>
+          <artifactId>lifecycle-mapping</artifactId>
+          <version>1.0.0</version>
+          <configuration>
+            <lifecycleMappingMetadata>
+              <pluginExecutions>
+                <pluginExecution>
+                  <pluginExecutionFilter>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-assembly-plugin</artifactId>
+                    <versionRange>[2.2,)</versionRange>
+                    <goals>
+                      <goal>single</goal>
+                    </goals>
+                  </pluginExecutionFilter>
+                  <action>
+                    <ignore></ignore>
+                  </action>
+                </pluginExecution>
+              </pluginExecutions>
+            </lifecycleMappingMetadata>
+          </configuration>
+        </plugin>
+      </plugins>
     </pluginManagement>
   </build>
 
@@ -456,7 +471,7 @@ under the License.
           <groupId>org.apache.hadoop</groupId>
           <artifactId>hadoop-core</artifactId>
           <version>${hadoop.version}</version>
-	  <scope>provided</scope>
+          <scope>provided</scope>
         </dependency>
       </dependencies>
 
@@ -498,7 +513,7 @@ under the License.
           <groupId>org.apache.hadoop</groupId>
           <artifactId>hadoop-core</artifactId>
           <version>${hadoop.version}</version>
-	  <scope>provided</scope>
+          <scope>provided</scope>
         </dependency>
       </dependencies>
 
@@ -540,7 +555,7 @@ under the License.
           <groupId>org.apache.hadoop</groupId>
           <artifactId>hadoop-core</artifactId>
           <version>${hadoop.version}</version>
-	  <scope>provided</scope>
+          <scope>provided</scope>
         </dependency>
       </dependencies>
       <build>
@@ -598,13 +613,13 @@ under the License.
           <groupId>commons-logging</groupId>
           <artifactId>commons-logging-api</artifactId>
           <version>1.0.4</version>
-	  <scope>runtime</scope>
+          <scope>runtime</scope>
         </dependency>
         <dependency>
           <groupId>commons-httpclient</groupId>
           <artifactId>commons-httpclient</artifactId>
           <version>3.0.1</version>
-	  <scope>runtime</scope>
+      <scope>runtime</scope>
         </dependency>
       </dependencies>
       <build>
@@ -646,19 +661,19 @@ under the License.
               <symbols>HADOOP_NON_SECURE,HADOOP_NON_SASL_RPC</symbols>
             </configuration>
           </plugin>
-	  <plugin>
-	    <groupId>org.apache.maven.plugins</groupId>
-	    <artifactId>maven-surefire-plugin</artifactId>
-	    <version>2.6</version>
-	    <configuration>
-	      <systemProperties>
-		<property>
-		  <name>prop.jarLocation</name>
-		  <value>../target/giraph-${project.version}-jar-with-dependencies.jar</value>
-		</property>
-	      </systemProperties>
-	    </configuration>
-	  </plugin>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-surefire-plugin</artifactId>
+            <version>2.6</version>
+            <configuration>
+              <systemProperties>
+                <property>
+                  <name>prop.jarLocation</name>
+                  <value>../target/giraph-${project.version}-jar-with-dependencies.jar</value>
+                </property>
+              </systemProperties>
+            </configuration>
+          </plugin>
         </plugins>
       </build>
     </profile>
@@ -675,23 +690,23 @@ under the License.
         <hadoop.version>0.23.1</hadoop.version>
       </properties>
       <dependencies>
-	<dependency>
-	  <groupId>org.apache.hadoop</groupId>
-	  <artifactId>hadoop-common</artifactId>
-	  <version>${hadoop.version}</version>
-	  <scope>provided</scope>
-	</dependency>
-	<dependency>
-	  <groupId>org.apache.hadoop</groupId>
-	  <artifactId>hadoop-mapreduce-client-core</artifactId>
-	  <version>${hadoop.version}</version>
-	  <scope>provided</scope>
-	</dependency>
-	<dependency>
-	  <groupId>org.apache.hadoop</groupId>
-	  <artifactId>hadoop-mapreduce-client-common</artifactId>
-	  <version>${hadoop.version}</version>
-	</dependency>
+        <dependency>
+          <groupId>org.apache.hadoop</groupId>
+          <artifactId>hadoop-common</artifactId>
+          <version>${hadoop.version}</version>
+          <scope>provided</scope>
+        </dependency>
+        <dependency>
+          <groupId>org.apache.hadoop</groupId>
+          <artifactId>hadoop-mapreduce-client-core</artifactId>
+          <version>${hadoop.version}</version>
+          <scope>provided</scope>
+        </dependency>
+        <dependency>
+          <groupId>org.apache.hadoop</groupId>
+          <artifactId>hadoop-mapreduce-client-common</artifactId>
+          <version>${hadoop.version}</version>
+        </dependency>
       </dependencies>
     </profile>
 
@@ -707,23 +722,23 @@ under the License.
         <hadoop.version>2.0.0-alpha</hadoop.version>
       </properties>
       <dependencies>
-	<dependency>
-	  <groupId>org.apache.hadoop</groupId>
-	  <artifactId>hadoop-common</artifactId>
-	  <version>${hadoop.version}</version>
-	  <scope>provided</scope>
-	</dependency>
-	<dependency>
-	  <groupId>org.apache.hadoop</groupId>
-	  <artifactId>hadoop-mapreduce-client-core</artifactId>
-	  <version>${hadoop.version}</version>
-	  <scope>provided</scope>
-	</dependency>
-	<dependency>
-	  <groupId>org.apache.hadoop</groupId>
-	  <artifactId>hadoop-mapreduce-client-common</artifactId>
-	  <version>${hadoop.version}</version>
-	</dependency>
+    <dependency>
+      <groupId>org.apache.hadoop</groupId>
+      <artifactId>hadoop-common</artifactId>
+      <version>${hadoop.version}</version>
+      <scope>provided</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.hadoop</groupId>
+      <artifactId>hadoop-mapreduce-client-core</artifactId>
+      <version>${hadoop.version}</version>
+      <scope>provided</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.hadoop</groupId>
+      <artifactId>hadoop-mapreduce-client-common</artifactId>
+      <version>${hadoop.version}</version>
+    </dependency>
       </dependencies>
     </profile>
 
@@ -739,41 +754,41 @@ under the License.
         <hadoop.version>3.0.0-SNAPSHOT</hadoop.version>
       </properties>
       <dependencies>
-	<dependency>
-	  <groupId>org.apache.hadoop</groupId>
-	  <artifactId>hadoop-common</artifactId>
-	  <version>${hadoop.version}</version>
-	  <scope>provided</scope>
-	</dependency>
-	<dependency>
-	  <groupId>org.apache.hadoop</groupId>
-	  <artifactId>hadoop-mapreduce-client-core</artifactId>
-	  <version>${hadoop.version}</version>
-	  <scope>provided</scope>
-	</dependency>
-	<dependency>
-	  <groupId>org.apache.hadoop</groupId>
-	  <artifactId>hadoop-mapreduce-client-common</artifactId>
-	  <version>${hadoop.version}</version>
-	  <scope>provided</scope>
-	</dependency>
-	<dependency>
-	  <groupId>org.apache.hadoop</groupId>
-	  <artifactId>hadoop-auth</artifactId>
-	  <version>${hadoop.version}</version>
-	  <scope>provided</scope>
-	</dependency>
-	<dependency>
-	  <groupId>commons-configuration</groupId>
-	  <artifactId>commons-configuration</artifactId>
-	  <version>1.6</version>
-	  <scope>runtime</scope>
-	</dependency>
+        <dependency>
+          <groupId>org.apache.hadoop</groupId>
+          <artifactId>hadoop-common</artifactId>
+          <version>${hadoop.version}</version>
+          <scope>provided</scope>
+        </dependency>
+        <dependency>
+          <groupId>org.apache.hadoop</groupId>
+          <artifactId>hadoop-mapreduce-client-core</artifactId>
+          <version>${hadoop.version}</version>
+          <scope>provided</scope>
+        </dependency>
+        <dependency>
+          <groupId>org.apache.hadoop</groupId>
+          <artifactId>hadoop-mapreduce-client-common</artifactId>
+          <version>${hadoop.version}</version>
+          <scope>provided</scope>
+        </dependency>
+        <dependency>
+          <groupId>org.apache.hadoop</groupId>
+          <artifactId>hadoop-auth</artifactId>
+          <version>${hadoop.version}</version>
+          <scope>provided</scope>
+        </dependency>
+        <dependency>
+          <groupId>commons-configuration</groupId>
+          <artifactId>commons-configuration</artifactId>
+          <version>1.6</version>
+          <scope>runtime</scope>
+        </dependency>
         <dependency>
           <groupId>commons-httpclient</groupId>
           <artifactId>commons-httpclient</artifactId>
           <version>3.0.1</version>
-	  <scope>runtime</scope>
+          <scope>runtime</scope>
         </dependency>
      </dependencies>
     </profile>



Mime
View raw message