Return-Path: X-Original-To: apmail-geronimo-xbean-dev-archive@minotaur.apache.org Delivered-To: apmail-geronimo-xbean-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3B7804250 for ; Wed, 8 Jun 2011 13:34:22 +0000 (UTC) Received: (qmail 89203 invoked by uid 500); 8 Jun 2011 13:34:22 -0000 Delivered-To: apmail-geronimo-xbean-dev-archive@geronimo.apache.org Received: (qmail 89157 invoked by uid 500); 8 Jun 2011 13:34:21 -0000 Mailing-List: contact xbean-dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: xbean-dev@geronimo.apache.org Delivered-To: mailing list xbean-dev@geronimo.apache.org Received: (qmail 89149 invoked by uid 99); 8 Jun 2011 13:34:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jun 2011 13:34:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jun 2011 13:34:19 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id C518910847E for ; Wed, 8 Jun 2011 13:33:58 +0000 (UTC) Date: Wed, 8 Jun 2011 13:33:58 +0000 (UTC) From: "Kevan Miller (JIRA)" To: xbean-dev@geronimo.apache.org Message-ID: <1574840049.3058.1307540038804.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1510162308.2276.1307510518910.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (XBEAN-176) use JarFile when possible in JarArchive for example MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/XBEAN-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045951#comment-13045951 ] Kevan Miller commented on XBEAN-176: ------------------------------------ Cool. Thanks Romain. However, your update is causing a JUnit test failure. Want to have a look? > use JarFile when possible in JarArchive for example > --------------------------------------------------- > > Key: XBEAN-176 > URL: https://issues.apache.org/jira/browse/XBEAN-176 > Project: XBean > Issue Type: Improvement > Components: finder > Reporter: Romain Manni-Bucau > Attachments: zipFile.patch, zipFile.patch > > > ZipFile is faster than ZipInputStream because it doesn't read a stream, it directly calls native methods so it can be faster to separate both cases. > (JarFile and JarInputStream have of course the same behavior) > (on my computer JarFile is 10 times faster than JarInputStream to list files contained in a jar) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira