geronimo-xbean-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Veithen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (XBEAN-92) UrlSet excludePaths() method throws a nullpointer exception if the pathString argument is null
Date Tue, 18 Aug 2009 15:29:29 GMT

    [ https://issues.apache.org/jira/browse/XBEAN-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744552#action_12744552
] 

Andreas Veithen commented on XBEAN-92:
--------------------------------------

I think the code is still not correct. I'm using OpenEJB 3.1.1 which depends on xbean-finder-shaded-3.6-r779512.jar.
Looking at the byte code of UrlSet#excludeJavaEndorsedDirs(), this version already contains
the change described above (usage of System#getProperty(String, String) instead of System#getProperty(String)).
It no longer throws a NullPointerException, but excludeJavaEndorsedDirs now removes all URLs
with the "file" protocol.

> UrlSet excludePaths() method throws a nullpointer exception if the pathString argument
is null
> ----------------------------------------------------------------------------------------------
>
>                 Key: XBEAN-92
>                 URL: https://issues.apache.org/jira/browse/XBEAN-92
>             Project: XBean
>          Issue Type: Bug
>          Components: finder
>         Environment: IBM JDK 5
>            Reporter: karan singh malhi
>            Assignee: Shawn Jiang
>            Priority: Blocker
>             Fix For: 3.5
>
>
> With IBM JDK 5, when we try to get the system property java.endorsed.dirs, it returns
null.  This is a critical issue as it prevents OpenEjb from starting 
> In UrlSet, the following method will lead to a NullPointerException:
>     public UrlSet excludeJavaEndorsedDirs() throws MalformedURLException {
>         return excludePaths(System.getProperty("java.endorsed.dirs"));
>     }
> This is because the excludePaths() method assumes that the pathString argument is always
non-null.
>    public UrlSet excludePaths(String pathString) throws MalformedURLException {
>         String[] paths = pathString.split(File.pathSeparator);
>         UrlSet urlSet = this;
>         for (String path : paths) {
>             File file = new File(path);
>             urlSet = urlSet.exclude(file);
>         }
>         return urlSet;
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message