From user-return-14977-apmail-geronimo-user-archive=geronimo.apache.org@geronimo.apache.org Sat Jul 17 21:47:46 2010 Return-Path: Delivered-To: apmail-geronimo-user-archive@www.apache.org Received: (qmail 72671 invoked from network); 17 Jul 2010 21:47:45 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 17 Jul 2010 21:47:45 -0000 Received: (qmail 27652 invoked by uid 500); 17 Jul 2010 21:47:45 -0000 Delivered-To: apmail-geronimo-user-archive@geronimo.apache.org Received: (qmail 27554 invoked by uid 500); 17 Jul 2010 21:47:44 -0000 Mailing-List: contact user-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: user@geronimo.apache.org List-Id: Delivered-To: mailing list user@geronimo.apache.org Received: (qmail 27547 invoked by uid 99); 17 Jul 2010 21:47:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Jul 2010 21:47:44 +0000 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=SPF_HELO_PASS,SPF_NEUTRAL,URI_HEX X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [216.139.236.158] (HELO kuber.nabble.com) (216.139.236.158) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Jul 2010 21:47:37 +0000 Received: from ben.nabble.com ([192.168.236.152]) by kuber.nabble.com with esmtp (Exim 4.63) (envelope-from ) id 1OaFB1-00019y-BT for user@geronimo.apache.org; Sat, 17 Jul 2010 14:44:07 -0700 Date: Sat, 17 Jul 2010 14:44:07 -0700 (PDT) From: rsumner To: user@geronimo.apache.org Message-ID: <1279403047350-975531.post@n3.nabble.com> In-Reply-To: <088DDDF6-732E-4BE7-BC61-79A524BEA6BB@yahoo.com> References: <1279090044324-965725.post@n3.nabble.com> <088DDDF6-732E-4BE7-BC61-79A524BEA6BB@yahoo.com> Subject: Re: inplace deployment and persistence.xml MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Sure thing. I spent the time to put some debug code in-place and figure out the problem. In PersistenceUnitBuilder.initContext(), there was no condition being put in place for the the fact that the moduleContext.getBaseDir() is not different regardless of whether or not the ModuleContext was constructed with inPlaceConfiguration dir not being null. Rather than changing the ModuleContext to help support a boolean for this value (which I think probably might have been cleaner), I went a layer up and checked to see if the configurationData of the rootEar had a null inPlaceConfigurationDir which would indicate the same condition from above. I adjusted the rootBaseFile and moduleBaseURI accordingly if it wasn't null from the when the MoudleContext was built. I've created a JIRA issue for it located here: https://issues.apache.org/jira/browse/GERONIMO-5452 In addition, I've attached the fix here that I wrote for the 2.1.6 branch. http://apache-geronimo.328035.n3.nabble.com/file/n975531/inplace-persistencebuilder.patch inplace-persistencebuilder.patch Thanks for allowing me the opportunity to contribute. -- View this message in context: http://apache-geronimo.328035.n3.nabble.com/inplace-deployment-and-persistence-xml-tp965725p975531.html Sent from the Users mailing list archive at Nabble.com.