geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viol...@apache.org
Subject svn commit: r1165562 - /geronimo/server/branches/2.1/plugins/connector/geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java
Date Tue, 06 Sep 2011 08:33:05 GMT
Author: violalu
Date: Tue Sep  6 08:33:05 2011
New Revision: 1165562

URL: http://svn.apache.org/viewvc?rev=1165562&view=rev
Log:
GERONIMO-6146 fix classcast exception when creating oracle rac datasource, replace String
with StringBuilder

Modified:
    geronimo/server/branches/2.1/plugins/connector/geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java

Modified: geronimo/server/branches/2.1/plugins/connector/geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/connector/geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java?rev=1165562&r1=1165561&r2=1165562&view=diff
==============================================================================
--- geronimo/server/branches/2.1/plugins/connector/geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java
(original)
+++ geronimo/server/branches/2.1/plugins/connector/geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/ManagedConnectionFactoryWrapper.java
Tue Sep  6 08:33:05 2011
@@ -195,12 +195,11 @@ public class ManagedConnectionFactoryWra
             if(value != null && value instanceof Properties){
                 Properties ps = (Properties) value;
                 if (!ps.isEmpty()) {
-                    String s = null;
+                    StringBuilder s = new StringBuilder();
                     for (Object o : ps.keySet()) {
                         String k = (String) o;
                         String v = ps.getProperty(k);
-                        s = k + "=" + v + ",";
-                        log.debug("Setting " + k + "=" + value);
+                        s = s.append(k).append("=").append(v).append(",");
                     }
                     delegate.setAttribute(name, s);
                     log.debug("Setting " + name + " value " + s);



Mime
View raw message