geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rwo...@apache.org
Subject svn commit: r1073628 - /geronimo/server/trunk/plugins/j2ee/geronimo-test-ddbean/src/main/java/org/apache/geronimo/deployment/tools/loader/AbstractDeployable.java
Date Wed, 23 Feb 2011 08:03:08 GMT
Author: rwonly
Date: Wed Feb 23 08:03:08 2011
New Revision: 1073628

URL: http://svn.apache.org/viewvc?rev=1073628&view=rev
Log:
GERONIMO-5829 Endless loop in org.apache.geronimo.deployment.tools.loader.AbstractDeployable
(thanks Fang Sheng Hao for the patch!)

Modified:
    geronimo/server/trunk/plugins/j2ee/geronimo-test-ddbean/src/main/java/org/apache/geronimo/deployment/tools/loader/AbstractDeployable.java

Modified: geronimo/server/trunk/plugins/j2ee/geronimo-test-ddbean/src/main/java/org/apache/geronimo/deployment/tools/loader/AbstractDeployable.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/j2ee/geronimo-test-ddbean/src/main/java/org/apache/geronimo/deployment/tools/loader/AbstractDeployable.java?rev=1073628&r1=1073627&r2=1073628&view=diff
==============================================================================
--- geronimo/server/trunk/plugins/j2ee/geronimo-test-ddbean/src/main/java/org/apache/geronimo/deployment/tools/loader/AbstractDeployable.java
(original)
+++ geronimo/server/trunk/plugins/j2ee/geronimo-test-ddbean/src/main/java/org/apache/geronimo/deployment/tools/loader/AbstractDeployable.java
Wed Feb 23 08:03:08 2011
@@ -54,10 +54,9 @@ public abstract class AbstractDeployable
         entries = new ArrayList<String>();
         Enumeration<String> paths = bundle.getEntryPaths("/");
         //TODO WTF?? if statement seems to be required????
-        if (paths.hasMoreElements()) {
-            for (String entry = paths.nextElement(); paths.hasMoreElements();) {
-                entries.add(entry);
-            }
+        while (paths.hasMoreElements()) {
+            String entry = paths.nextElement();
+            entries.add(entry);
         }
     }
 



Mime
View raw message