Return-Path: Delivered-To: apmail-geronimo-scm-archive@www.apache.org Received: (qmail 26348 invoked from network); 18 Jan 2011 14:16:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 18 Jan 2011 14:16:38 -0000 Received: (qmail 14213 invoked by uid 500); 18 Jan 2011 14:16:38 -0000 Delivered-To: apmail-geronimo-scm-archive@geronimo.apache.org Received: (qmail 14075 invoked by uid 500); 18 Jan 2011 14:16:35 -0000 Mailing-List: contact scm-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list scm@geronimo.apache.org Received: (qmail 14068 invoked by uid 99); 18 Jan 2011 14:16:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jan 2011 14:16:34 +0000 X-ASF-Spam-Status: No, hits=-1999.4 required=10.0 tests=ALL_TRUSTED,HK_RANDOM_ENVFROM X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jan 2011 14:16:34 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id E00462388A36; Tue, 18 Jan 2011 14:16:07 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1060388 - in /geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail: authentication/DigestMD5Authenticator.java store/pop3/connection/POP3Connection.java Date: Tue, 18 Jan 2011 14:16:07 -0000 To: scm@geronimo.apache.org From: rickmcguire@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110118141607.E00462388A36@eris.apache.org> Author: rickmcguire Date: Tue Jan 18 14:16:07 2011 New Revision: 1060388 URL: http://svn.apache.org/viewvc?rev=1060388&view=rev Log: GERONIMO-5760 Wrong encoding specified in javamail providers. Modified: geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/connection/POP3Connection.java Modified: geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java URL: http://svn.apache.org/viewvc/geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java?rev=1060388&r1=1060387&r2=1060388&view=diff ============================================================================== --- geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java (original) +++ geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java Tue Jan 18 14:16:07 2011 @@ -272,7 +272,7 @@ public class DigestMD5Authenticator impl digest.update(authString.getBytes("US-ASCII")); // this gets added on to the client response - String responseString = clientResponse + new String(Hex.encode(digest.digest()), "US_ASCII"); + String responseString = clientResponse + new String(Hex.encode(digest.digest()), "US-ASCII"); // and this gets fed back into the digest digest.update(responseString.getBytes("US-ASCII")); Modified: geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/connection/POP3Connection.java URL: http://svn.apache.org/viewvc/geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/connection/POP3Connection.java?rev=1060388&r1=1060387&r2=1060388&view=diff ============================================================================== --- geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/connection/POP3Connection.java (original) +++ geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/connection/POP3Connection.java Tue Jan 18 14:16:07 2011 @@ -632,7 +632,7 @@ public class POP3Connection extends Mail byte[] challenge = response.decodeChallengeResponse(); try { - String responseString = new String(Base64.encode(authenticator.evaluateChallenge(challenge)), "US_ASCII"); + String responseString = new String(Base64.encode(authenticator.evaluateChallenge(challenge)), "US-ASCII"); // have the authenticator evaluate and send back the encoded response. response = sendCommand(responseString);