geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rickmcgu...@apache.org
Subject svn commit: r1060388 - in /geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail: authentication/DigestMD5Authenticator.java store/pop3/connection/POP3Connection.java
Date Tue, 18 Jan 2011 14:16:07 GMT
Author: rickmcguire
Date: Tue Jan 18 14:16:07 2011
New Revision: 1060388

URL: http://svn.apache.org/viewvc?rev=1060388&view=rev
Log:
GERONIMO-5760 Wrong encoding specified in javamail providers.


Modified:
    geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java
    geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/connection/POP3Connection.java

Modified: geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java
URL: http://svn.apache.org/viewvc/geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java?rev=1060388&r1=1060387&r2=1060388&view=diff
==============================================================================
--- geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java
(original)
+++ geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java
Tue Jan 18 14:16:07 2011
@@ -272,7 +272,7 @@ public class DigestMD5Authenticator impl
             digest.update(authString.getBytes("US-ASCII"));
 
             // this gets added on to the client response
-            String responseString = clientResponse + new String(Hex.encode(digest.digest()),
"US_ASCII");
+            String responseString = clientResponse + new String(Hex.encode(digest.digest()),
"US-ASCII");
             // and this gets fed back into the digest
             digest.update(responseString.getBytes("US-ASCII"));
 

Modified: geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/connection/POP3Connection.java
URL: http://svn.apache.org/viewvc/geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/connection/POP3Connection.java?rev=1060388&r1=1060387&r2=1060388&view=diff
==============================================================================
--- geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/connection/POP3Connection.java
(original)
+++ geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/connection/POP3Connection.java
Tue Jan 18 14:16:07 2011
@@ -632,7 +632,7 @@ public class POP3Connection extends Mail
                 byte[] challenge = response.decodeChallengeResponse();
 
                 try {
-                    String responseString = new String(Base64.encode(authenticator.evaluateChallenge(challenge)),
"US_ASCII");
+                    String responseString = new String(Base64.encode(authenticator.evaluateChallenge(challenge)),
"US-ASCII");
 
                     // have the authenticator evaluate and send back the encoded response.
                     response = sendCommand(responseString);



Mime
View raw message