geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rickmcgu...@apache.org
Subject svn commit: r940426 - /geronimo/server/trunk/framework/modules/geronimo-kernel/src/test/java/org/apache/geronimo/kernel/rmi/RMIClassLoaderSpiImplTest.java
Date Mon, 03 May 2010 12:08:48 GMT
Author: rickmcguire
Date: Mon May  3 12:08:48 2010
New Revision: 940426

URL: http://svn.apache.org/viewvc?rev=940426&view=rev
Log:
file.toURI().toURL() updates hit one that should not have been

Modified:
    geronimo/server/trunk/framework/modules/geronimo-kernel/src/test/java/org/apache/geronimo/kernel/rmi/RMIClassLoaderSpiImplTest.java

Modified: geronimo/server/trunk/framework/modules/geronimo-kernel/src/test/java/org/apache/geronimo/kernel/rmi/RMIClassLoaderSpiImplTest.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-kernel/src/test/java/org/apache/geronimo/kernel/rmi/RMIClassLoaderSpiImplTest.java?rev=940426&r1=940425&r2=940426&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-kernel/src/test/java/org/apache/geronimo/kernel/rmi/RMIClassLoaderSpiImplTest.java
(original)
+++ geronimo/server/trunk/framework/modules/geronimo-kernel/src/test/java/org/apache/geronimo/kernel/rmi/RMIClassLoaderSpiImplTest.java
Mon May  3 12:08:48 2010
@@ -40,7 +40,11 @@ public class RMIClassLoaderSpiImplTest e
     protected void setUp() throws Exception {
         File dir = new File(System.getProperty("user.home"));
 
-        baseURL = dir.toURI().toURL().toString();
+        // NOTE:  Do not change this to use toURL().toURI().toString().
+        // This messes up Windows tests where directories can have blanks.
+        // The URL encoding gets applied twice, resulting in %20 encodings
+        // getting converted into invalid %2520 encodings
+        baseURL = dir.toURL().toString();
         if (baseURL.endsWith("/")) {
             baseURL = baseURL.substring(0, baseURL.length() - 1);
         }



Mime
View raw message