Return-Path: Delivered-To: apmail-geronimo-scm-archive@www.apache.org Received: (qmail 25928 invoked from network); 13 May 2009 11:52:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 13 May 2009 11:52:13 -0000 Received: (qmail 45026 invoked by uid 500); 13 May 2009 11:52:13 -0000 Delivered-To: apmail-geronimo-scm-archive@geronimo.apache.org Received: (qmail 44974 invoked by uid 500); 13 May 2009 11:52:13 -0000 Mailing-List: contact scm-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list scm@geronimo.apache.org Received: (qmail 44965 invoked by uid 99); 13 May 2009 11:52:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 May 2009 11:52:12 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 May 2009 11:52:10 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 93E912388874; Wed, 13 May 2009 11:51:50 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r774284 - in /geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint: BlueprintExtender.java context/BlueprintContextImpl.java Date: Wed, 13 May 2009 11:51:50 -0000 To: scm@geronimo.apache.org From: gnodet@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090513115150.93E912388874@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: gnodet Date: Wed May 13 11:51:49 2009 New Revision: 774284 URL: http://svn.apache.org/viewvc?rev=774284&view=rev Log: Add some todos Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/BlueprintExtender.java geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintContextImpl.java Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/BlueprintExtender.java URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/BlueprintExtender.java?rev=774284&r1=774283&r2=774284&view=diff ============================================================================== --- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/BlueprintExtender.java (original) +++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/BlueprintExtender.java Wed May 13 11:51:49 2009 @@ -76,6 +76,10 @@ public void stop(BundleContext context) { LOGGER.debug("Stopping blueprint extender..."); + // TODO: we should order the blueprint context destruction wrt service exports / dependencies + // TODO: also if a blueprint bundle is being stopped at the same time (this could happen if the framework + // is shut down, we should not wait for the blueprint context to be destroyed if it is already being + // destroyed by the extender List bundles = new ArrayList(contextMap.keySet()); for (Bundle bundle : bundles) { destroyContext(bundle); Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintContextImpl.java URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintContextImpl.java?rev=774284&r1=774283&r2=774284&view=diff ============================================================================== --- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintContextImpl.java (original) +++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintContextImpl.java Wed May 13 11:51:49 2009 @@ -228,6 +228,12 @@ return; } case InitialReferencesSatisfied: + // TODO: we should always register ServiceFactory in all cases. + // the reason is that the trigger service creation may actually trigger the activation of + // the bundle if the service properties reference any other components (thus loading a class + // from the bundle and activating it) + // the lazy activation should be a best effot and the lazy creation of services should be + // done in all cases if (lazyActivation) { registerTriggerServices(); state = State.WaitForTrigger;