Return-Path: Delivered-To: apmail-geronimo-scm-archive@www.apache.org Received: (qmail 79292 invoked from network); 9 May 2009 05:04:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 9 May 2009 05:04:31 -0000 Received: (qmail 59642 invoked by uid 500); 9 May 2009 05:04:31 -0000 Delivered-To: apmail-geronimo-scm-archive@geronimo.apache.org Received: (qmail 59585 invoked by uid 500); 9 May 2009 05:04:30 -0000 Mailing-List: contact scm-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list scm@geronimo.apache.org Received: (qmail 59572 invoked by uid 99); 9 May 2009 05:04:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 May 2009 05:04:30 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 09 May 2009 05:04:27 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id A1E8223888A2; Sat, 9 May 2009 05:04:06 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r773163 - /geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintObjectRecipe.java Date: Sat, 09 May 2009 05:04:06 -0000 To: scm@geronimo.apache.org From: gawor@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090509050406.A1E8223888A2@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: gawor Date: Sat May 9 05:04:06 2009 New Revision: 773163 URL: http://svn.apache.org/viewvc?rev=773163&view=rev Log: not needed Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintObjectRecipe.java Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintObjectRecipe.java URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintObjectRecipe.java?rev=773163&r1=773162&r2=773163&view=diff ============================================================================== --- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintObjectRecipe.java (original) +++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintObjectRecipe.java Sat May 9 05:04:06 2009 @@ -153,11 +153,7 @@ List args = new ArrayList(); for (int i = 0; beanArguments != null && i < beanArguments.size(); i++) { BeanArgument argument = beanArguments.get(i); - String valueType = argument.getValueType(); - if (valueType == null) { - // check if valueType is set on the element - valueType = getValueType(argument.getValue()); - } + String valueType = argument.getValueType(); Class type = loadClass(valueType); Object obj = arguments.get(i); if (type != null) { @@ -206,15 +202,7 @@ } return true; } - - private String getValueType(Metadata metadata) { - if (metadata instanceof ValueMetadata) { - ValueMetadata stringValue = (ValueMetadata) metadata; - return stringValue.getTypeName(); - } - return null; - } - + private Class loadClass(String typeName) throws ConstructionException { if (typeName == null) { return null;