geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gno...@apache.org
Subject svn commit: r779858 - in /geronimo/sandbox/blueprint: blueprint-api/src/main/java/org/osgi/service/blueprint/container/ blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/ blueprint-core/src/main/java/org/apache/geronimo/blueprint/c...
Date Fri, 29 May 2009 06:21:36 GMT
Author: gnodet
Date: Fri May 29 06:21:36 2009
New Revision: 779858

URL: http://svn.apache.org/viewvc?rev=779858&view=rev
Log:
Add todos

Modified:
    geronimo/sandbox/blueprint/blueprint-api/src/main/java/org/osgi/service/blueprint/container/ServiceUnavailableException.java
    geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmNamespaceHandler.java
    geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmPropertyPlaceholder.java
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/AbstractServiceReferenceRecipe.java
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/RefCollectionRecipe.java

Modified: geronimo/sandbox/blueprint/blueprint-api/src/main/java/org/osgi/service/blueprint/container/ServiceUnavailableException.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-api/src/main/java/org/osgi/service/blueprint/container/ServiceUnavailableException.java?rev=779858&r1=779857&r2=779858&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-api/src/main/java/org/osgi/service/blueprint/container/ServiceUnavailableException.java
(original)
+++ geronimo/sandbox/blueprint/blueprint-api/src/main/java/org/osgi/service/blueprint/container/ServiceUnavailableException.java
Fri May 29 06:21:36 2009
@@ -16,6 +16,9 @@
  */
 package org.osgi.service.blueprint.container;
 
+/**
+ * TODO: need to update this one wrt the official API, but it brings a dependency on osgi
1.5
+ */
 public class ServiceUnavailableException extends RuntimeException {
     
     private Class serviceType;

Modified: geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmNamespaceHandler.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmNamespaceHandler.java?rev=779858&r1=779857&r2=779858&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmNamespaceHandler.java
(original)
+++ geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmNamespaceHandler.java
Fri May 29 06:21:36 2009
@@ -109,7 +109,7 @@
         return getClass().getResource("blueprint-cm.xsd");
     }
 
-    public ComponentMetadata parse(Element element, ParserContext context) {
+    public Metadata parse(Element element, ParserContext context) {
         LOGGER.debug("Parsing element {" + element.getNamespaceURI() + "}" + element.getLocalName());
         ComponentDefinitionRegistry registry = context.getComponentDefinitionRegistry();
         createConfigAdminProxy(context, registry);
@@ -459,7 +459,7 @@
     private String generateId(ParserContext context) {
         String id;
         do {
-            id = "#cm-" + ++idCounter;
+            id = ".cm-" + ++idCounter;
         } while (context.getComponentDefinitionRegistry().containsComponentDefinition(id));
         return id;
     }

Modified: geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmPropertyPlaceholder.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmPropertyPlaceholder.java?rev=779858&r1=779857&r2=779858&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmPropertyPlaceholder.java
(original)
+++ geronimo/sandbox/blueprint/blueprint-cm/src/main/java/org/apache/geronimo/blueprint/compendium/cm/CmPropertyPlaceholder.java
Fri May 29 06:21:36 2009
@@ -82,6 +82,8 @@
 
     @Override
     protected Metadata processValueMetadata(ValueMetadata metadata) {
+        // TODO: we need to wrap the old metadata so that multiple placeholders can work
together
+        // TODO: move this code in the parent class
         return new LateBindingValueMetadata(metadata.getStringValue(), metadata.getTypeName());
     }
 

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/AbstractServiceReferenceRecipe.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/AbstractServiceReferenceRecipe.java?rev=779858&r1=779857&r2=779858&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/AbstractServiceReferenceRecipe.java
(original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/AbstractServiceReferenceRecipe.java
Fri May 29 06:21:36 2009
@@ -217,6 +217,11 @@
         //       or have an optional import an asm / cglib and use JDK proxies if not present
         //       also, check what the spec will say about that (optional imports could be
fine if
         //       the spec does not mandate support for classes proxying
+        // TODO: the spec mandates interfaces now, which means JDK proxies can be used
+        //       proxying non final classes is an implementation specific enhancement and
should be triggered
+        //       by a custom attribute on the xml
+        // TODO: cglib is faster, but it should now be optional
+        // TODO: do we need to proxy equals/toString/hashCode ?
         Enhancer e = new Enhancer();
         e.setClassLoader(proxyClassLoader);
         e.setSuperclass(getTargetClass(interfaces));

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/RefCollectionRecipe.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/RefCollectionRecipe.java?rev=779858&r1=779857&r2=779858&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/RefCollectionRecipe.java
(original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/container/RefCollectionRecipe.java
Fri May 29 06:21:36 2009
@@ -154,6 +154,8 @@
                     }
                 } else {
                     dispatcher = new ServiceDispatcher(reference);
+                    // TODO: it seems we need to make this greedy-proxying stuff an implementation
specific
+                    // TODO: feature which could be activated by a custom attribute on the
xml
                     dispatcher.proxy = createProxy(dispatcher, Arrays.asList((String[]) reference.getProperty(Constants.OBJECTCLASS)));
                     synchronized (collection) {
                         collection.addDispatcher(dispatcher);



Mime
View raw message