geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gno...@apache.org
Subject svn commit: r774284 - in /geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint: BlueprintExtender.java context/BlueprintContextImpl.java
Date Wed, 13 May 2009 11:51:50 GMT
Author: gnodet
Date: Wed May 13 11:51:49 2009
New Revision: 774284

URL: http://svn.apache.org/viewvc?rev=774284&view=rev
Log:
Add some todos

Modified:
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/BlueprintExtender.java
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintContextImpl.java

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/BlueprintExtender.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/BlueprintExtender.java?rev=774284&r1=774283&r2=774284&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/BlueprintExtender.java
(original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/BlueprintExtender.java
Wed May 13 11:51:49 2009
@@ -76,6 +76,10 @@
 
     public void stop(BundleContext context) {
         LOGGER.debug("Stopping blueprint extender...");
+        // TODO: we should order the blueprint context destruction wrt service exports /
dependencies
+        // TODO: also if a blueprint bundle is being stopped at the same time (this could
happen if the framework
+        //        is shut down, we should not wait for the blueprint context to be destroyed
if it is already being
+        //        destroyed by the extender
         List<Bundle> bundles = new ArrayList<Bundle>(contextMap.keySet());
         for (Bundle bundle : bundles) {
             destroyContext(bundle);

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintContextImpl.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintContextImpl.java?rev=774284&r1=774283&r2=774284&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintContextImpl.java
(original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/BlueprintContextImpl.java
Wed May 13 11:51:49 2009
@@ -228,6 +228,12 @@
                             return;
                         }
                     case InitialReferencesSatisfied:
+                        // TODO: we should always register ServiceFactory in all cases.
+                        //       the reason is that the trigger service creation may actually
trigger the activation of
+                        //       the bundle if the service properties reference any other
components (thus loading a class
+                        //       from the bundle and activating it)
+                        //       the lazy activation should be a best effot and the lazy
creation of services should be
+                        //       done in all cases
                         if (lazyActivation) {
                             registerTriggerServices();
                             state = State.WaitForTrigger;                            



Mime
View raw message