geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gno...@apache.org
Subject svn commit: r768516 - /geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/
Date Sat, 25 Apr 2009 11:51:39 GMT
Author: gnodet
Date: Sat Apr 25 11:51:38 2009
New Revision: 768516

URL: http://svn.apache.org/viewvc?rev=768516&view=rev
Log:
Make sure we create new lists to avoid using immutable lists for example

Modified:
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/BeanMetadataImpl.java
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/CollectionMetadataImpl.java
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/MapMetadataImpl.java
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/PropsMetadataImpl.java
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/ServiceMetadataImpl.java
    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/ServiceReferenceMetadataImpl.java

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/BeanMetadataImpl.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/BeanMetadataImpl.java?rev=768516&r1=768515&r2=768516&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/BeanMetadataImpl.java
(original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/BeanMetadataImpl.java
Sat Apr 25 11:51:38 2009
@@ -104,7 +104,7 @@
     }
 
     public void setArguments(List<BeanArgument> arguments) {
-        this.arguments = arguments;
+        this.arguments = arguments != null ? new ArrayList<BeanArgument>(arguments)
: null;
     }
 
     public void addArgument(BeanArgument argument) {
@@ -143,7 +143,7 @@
     }
 
     public void setProperties(List<BeanProperty> properties) {
-        this.properties = properties;
+        this.properties = properties != null ? new ArrayList<BeanProperty>(properties)
: null;
     }
 
     public void addProperty(BeanProperty property) {
@@ -214,7 +214,7 @@
     }
 
     public void setExplicitDependencies(List<String> explicitDependencies) {
-        this.explicitDependencies = explicitDependencies;
+        this.explicitDependencies = explicitDependencies != null ? new ArrayList<String>(explicitDependencies)
: null;
     }
 
     public void addExplicitDependency(String explicitDependency) {

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/CollectionMetadataImpl.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/CollectionMetadataImpl.java?rev=768516&r1=768515&r2=768516&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/CollectionMetadataImpl.java
(original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/CollectionMetadataImpl.java
Sat Apr 25 11:51:38 2009
@@ -80,7 +80,7 @@
     }
 
     public void setValues(List<Metadata> values) {
-        this.values = values;
+        this.values = values != null ? new ArrayList<Metadata>(values) : null;
     }
 
     public void addValue(Metadata value) {

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/MapMetadataImpl.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/MapMetadataImpl.java?rev=768516&r1=768515&r2=768516&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/MapMetadataImpl.java
(original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/MapMetadataImpl.java
Sat Apr 25 11:51:38 2009
@@ -82,7 +82,7 @@
     }
 
     public void setEntries(List<MapEntry> entries) {
-        this.entries = entries;
+        this.entries = entries != null ? new ArrayList<MapEntry>(entries) : null;
     }
 
     public void addEntry(MapEntry entry) {

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/PropsMetadataImpl.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/PropsMetadataImpl.java?rev=768516&r1=768515&r2=768516&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/PropsMetadataImpl.java
(original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/PropsMetadataImpl.java
Sat Apr 25 11:51:38 2009
@@ -60,7 +60,7 @@
     }
 
     public void setEntries(List<MapEntry> entries) {
-        this.entries = entries;
+        this.entries = entries != null ? new ArrayList<MapEntry>(entries) : null;
     }
 
     public void addEntry(MapEntry entry) {

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/ServiceMetadataImpl.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/ServiceMetadataImpl.java?rev=768516&r1=768515&r2=768516&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/ServiceMetadataImpl.java
(original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/ServiceMetadataImpl.java
Sat Apr 25 11:51:38 2009
@@ -82,7 +82,7 @@
     }
 
     public void setInterfaceNames(List<String> interfaceNames) {
-        this.interfaceNames = interfaceNames;
+        this.interfaceNames = interfaceNames != null ? new ArrayList<String>(interfaceNames)
: null;
     }
 
     public void addInterfaceName(String interfaceName) {
@@ -115,7 +115,7 @@
     }
 
     public void setServiceProperties(List<MapEntry> serviceProperties) {
-        this.serviceProperties = serviceProperties;
+        this.serviceProperties = serviceProperties != null ? new ArrayList<MapEntry>(serviceProperties)
: null;
     }
 
     public void addServiceProperty(MapEntry serviceProperty) {

Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/ServiceReferenceMetadataImpl.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/ServiceReferenceMetadataImpl.java?rev=768516&r1=768515&r2=768516&view=diff
==============================================================================
--- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/ServiceReferenceMetadataImpl.java
(original)
+++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/reflect/ServiceReferenceMetadataImpl.java
Sat Apr 25 11:51:38 2009
@@ -69,7 +69,7 @@
     }
 
     public void setInterfaceNames(List<String> interfaceNames) {
-        this.interfaceNames = interfaceNames;
+        this.interfaceNames = interfaceNames != null ? new ArrayList<String>(interfaceNames)
: null;
     }
 
     public void addInterfaceName(String interfaceName) {
@@ -110,7 +110,7 @@
     }
 
     public void setServiceListeners(Collection<Listener> listeners) {
-        this.serviceListeners = listeners;
+        this.serviceListeners = listeners != null ? new ArrayList<Listener>(listeners)
: null;
     }
 
     public void addServiceListener(Listener bindingListenerMetadata) {



Mime
View raw message