geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From djen...@apache.org
Subject svn commit: r724559 - /geronimo/server/trunk/plugins/openejb/geronimo-openejb-builder/src/main/java/org/apache/geronimo/openejb/deployment/EjbModuleBuilder.java
Date Tue, 09 Dec 2008 00:06:01 GMT
Author: djencks
Date: Mon Dec  8 16:06:01 2008
New Revision: 724559

URL: http://svn.apache.org/viewvc?rev=724559&view=rev
Log:
GERONIMO-4452 fix what looks like a nested loop that shouldn't be

Modified:
    geronimo/server/trunk/plugins/openejb/geronimo-openejb-builder/src/main/java/org/apache/geronimo/openejb/deployment/EjbModuleBuilder.java

Modified: geronimo/server/trunk/plugins/openejb/geronimo-openejb-builder/src/main/java/org/apache/geronimo/openejb/deployment/EjbModuleBuilder.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/openejb/geronimo-openejb-builder/src/main/java/org/apache/geronimo/openejb/deployment/EjbModuleBuilder.java?rev=724559&r1=724558&r2=724559&view=diff
==============================================================================
--- geronimo/server/trunk/plugins/openejb/geronimo-openejb-builder/src/main/java/org/apache/geronimo/openejb/deployment/EjbModuleBuilder.java
(original)
+++ geronimo/server/trunk/plugins/openejb/geronimo-openejb-builder/src/main/java/org/apache/geronimo/openejb/deployment/EjbModuleBuilder.java
Mon Dec  8 16:06:01 2008
@@ -883,10 +883,11 @@
             // add a dependency from the module to the ra so we can be assured the mdb
             // container exists when this app is started
             ejbModuleGBeanData.addDependency(resourceAdapterAbstractName);
-            for(MessageDrivenBeanInfo mdbInfo:mdbs.values()){
-                if(mdbInfo != null && mdbInfo.containerId == null){
-                    throw new DeploymentException("No Resource Adapter defined for MDB '"
+ mdbInfo.ejbName + "'");
-                }
+        }
+        //check that all the mdbs have resource adapters identified.
+        for(MessageDrivenBeanInfo mdbInfo:mdbs.values()){
+            if(mdbInfo != null && mdbInfo.containerId == null){
+                throw new DeploymentException("No Resource Adapter defined for MDB '" + mdbInfo.ejbName
+ "'");
             }
         }
     }



Mime
View raw message