geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdil...@apache.org
Subject svn commit: r701787 - /geronimo/gshell/trunk/gshell-commands/gshell-vfs/src/main/java/org/apache/geronimo/gshell/commands/vfs/CatAction.java
Date Sun, 05 Oct 2008 13:06:57 GMT
Author: jdillon
Date: Sun Oct  5 06:06:57 2008
New Revision: 701787

URL: http://svn.apache.org/viewvc?rev=701787&view=rev
Log:
Don't append extra \n

Modified:
    geronimo/gshell/trunk/gshell-commands/gshell-vfs/src/main/java/org/apache/geronimo/gshell/commands/vfs/CatAction.java

Modified: geronimo/gshell/trunk/gshell-commands/gshell-vfs/src/main/java/org/apache/geronimo/gshell/commands/vfs/CatAction.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-commands/gshell-vfs/src/main/java/org/apache/geronimo/gshell/commands/vfs/CatAction.java?rev=701787&r1=701786&r2=701787&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-commands/gshell-vfs/src/main/java/org/apache/geronimo/gshell/commands/vfs/CatAction.java
(original)
+++ geronimo/gshell/trunk/gshell-commands/gshell-vfs/src/main/java/org/apache/geronimo/gshell/commands/vfs/CatAction.java
Sun Oct  5 06:06:57 2008
@@ -73,7 +73,7 @@
         log.debug("Content encoding: {}", info.getContentEncoding());
 
         //
-        // TODO: Only cat files which we think are text
+        // TODO: Only cat files which we think are text, or warn if its not, allow flag to
force
         //
 
         log.debug("Displaying file: {}", file.getName());
@@ -88,8 +88,6 @@
 
         closeFile(file);
         
-        io.out.println();
-
         return Result.SUCCESS;
     }
 
@@ -99,6 +97,10 @@
 
         while ((line = reader.readLine()) != null) {
             if (displayLineNumbers) {
+                //
+                // TODO: Replace with io.out.printf()
+                //
+
                 String gutter = StringUtils.leftPad(String.valueOf(lineno++), 6);
                 io.out.print(gutter);
                 io.out.print("  ");



Mime
View raw message