geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdil...@apache.org
Subject svn commit: r700010 - in /geronimo/gshell/trunk/gshell-commands/gshell-optional/src/main: java/org/apache/geronimo/gshell/commands/optional/ExecuteAction.java resources/org/apache/geronimo/gshell/commands/optional/ExecuteAction.properties
Date Mon, 29 Sep 2008 07:38:31 GMT
Author: jdillon
Date: Mon Sep 29 00:38:30 2008
New Revision: 700010

URL: http://svn.apache.org/viewvc?rev=700010&view=rev
Log:
Try to make 'exec' work again

Modified:
    geronimo/gshell/trunk/gshell-commands/gshell-optional/src/main/java/org/apache/geronimo/gshell/commands/optional/ExecuteAction.java
    geronimo/gshell/trunk/gshell-commands/gshell-optional/src/main/resources/org/apache/geronimo/gshell/commands/optional/ExecuteAction.properties

Modified: geronimo/gshell/trunk/gshell-commands/gshell-optional/src/main/java/org/apache/geronimo/gshell/commands/optional/ExecuteAction.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-commands/gshell-optional/src/main/java/org/apache/geronimo/gshell/commands/optional/ExecuteAction.java?rev=700010&r1=700009&r2=700010&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-commands/gshell-optional/src/main/java/org/apache/geronimo/gshell/commands/optional/ExecuteAction.java
(original)
+++ geronimo/gshell/trunk/gshell-commands/gshell-optional/src/main/java/org/apache/geronimo/gshell/commands/optional/ExecuteAction.java
Mon Sep 29 00:38:30 2008
@@ -39,21 +39,16 @@
 {
     private final Logger log = LoggerFactory.getLogger(getClass());
 
-    private ProcessBuilder builder;
-
     @Argument(required=true)
     private List<String> args;
 
+    // TODO: Support setting the process directory and envrionment muck
+
     public Object execute(final CommandContext context) throws Exception {
         assert context != null;
-
         IO io = context.getIo();
 
-        //
-        // FIXME: Seems we are missing the builder here... oops
-        //
-        
-        assert builder != null;
+        ProcessBuilder builder = new ProcessBuilder(args);
 
         log.info("Executing: {}", builder.command());
 
@@ -66,7 +61,6 @@
         log.debug("Waiting for process to exit...");
 
         int status = p.waitFor();
-
         
         log.info("Process exited w/status: {}", status);
 

Modified: geronimo/gshell/trunk/gshell-commands/gshell-optional/src/main/resources/org/apache/geronimo/gshell/commands/optional/ExecuteAction.properties
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-commands/gshell-optional/src/main/resources/org/apache/geronimo/gshell/commands/optional/ExecuteAction.properties?rev=700010&r1=700009&r2=700010&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-commands/gshell-optional/src/main/resources/org/apache/geronimo/gshell/commands/optional/ExecuteAction.properties
(original)
+++ geronimo/gshell/trunk/gshell-commands/gshell-optional/src/main/resources/org/apache/geronimo/gshell/commands/optional/ExecuteAction.properties
Mon Sep 29 00:38:30 2008
@@ -26,6 +26,7 @@
 command.description=Execute system processes.
 
 command.argument.args=Process arguments
+command.argument.args.token=ARGUMENTS
 
 command.manual=\
   TODO: exec manual
\ No newline at end of file



Mime
View raw message