geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdil...@apache.org
Subject svn commit: r699829 - /geronimo/gshell/trunk/gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/wisdom/config/PluginParser.java
Date Sun, 28 Sep 2008 14:40:19 GMT
Author: jdillon
Date: Sun Sep 28 07:40:18 2008
New Revision: 699829

URL: http://svn.apache.org/viewvc?rev=699829&view=rev
Log:
Prefer the ConfigurableCommandCompleter's constructor to is "completers" property when parsing
<gshell:plugin> muck

Modified:
    geronimo/gshell/trunk/gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/wisdom/config/PluginParser.java

Modified: geronimo/gshell/trunk/gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/wisdom/config/PluginParser.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/wisdom/config/PluginParser.java?rev=699829&r1=699828&r2=699829&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/wisdom/config/PluginParser.java
(original)
+++ geronimo/gshell/trunk/gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/wisdom/config/PluginParser.java
Sun Sep 28 07:40:18 2008
@@ -435,7 +435,7 @@
         private BeanDefinitionBuilder parseCommandCompleters(final Element element) {
             assert element != null;
 
-            BeanDefinitionBuilder command = BeanDefinitionBuilder.rootBeanDefinition(ConfigurableCommandCompleter.class);
+            BeanDefinitionBuilder completer = BeanDefinitionBuilder.rootBeanDefinition(ConfigurableCommandCompleter.class);
 
             ManagedList completers = new ManagedList();
 
@@ -449,7 +449,7 @@
                 }
                 else if (DomUtils.nodeNameEquals(child, REF)) {
                     BeanDefinitionParserDelegate parser = createBeanDefinitionParserDelegate(child);
-                    RuntimeBeanReference ref = (RuntimeBeanReference) parser.parsePropertySubElement(child,
command.getRawBeanDefinition());
+                    RuntimeBeanReference ref = (RuntimeBeanReference) parser.parsePropertySubElement(child,
completer.getRawBeanDefinition());
                     // noinspection unchecked
                     completers.add(ref);
                 }
@@ -459,9 +459,9 @@
                 }
             }
 
-            command.addPropertyValue(COMPLETERS, completers);
+            completer.addConstructorArgValue(completers);
 
-            return command;
+            return completer;
         }
 
         //



Mime
View raw message