geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdil...@apache.org
Subject svn commit: r699409 - in /geronimo/gshell/trunk: gshell-api/src/main/java/org/apache/geronimo/gshell/command/ gshell-support/gshell-plexus/src/main/java/org/apache/geronimo/gshell/plexus/ gshell-support/gshell-spring/src/main/java/org/apache/geronimo/g...
Date Fri, 26 Sep 2008 16:57:57 GMT
Author: jdillon
Date: Fri Sep 26 09:57:57 2008
New Revision: 699409

URL: http://svn.apache.org/viewvc?rev=699409&view=rev
Log:
Tidy

Modified:
    geronimo/gshell/trunk/gshell-api/src/main/java/org/apache/geronimo/gshell/command/CommandCompleter.java
    geronimo/gshell/trunk/gshell-support/gshell-plexus/src/main/java/org/apache/geronimo/gshell/plexus/Slf4jLoggingManager.java
    geronimo/gshell/trunk/gshell-support/gshell-spring/src/main/java/org/apache/geronimo/gshell/spring/LoggingProcessor.java

Modified: geronimo/gshell/trunk/gshell-api/src/main/java/org/apache/geronimo/gshell/command/CommandCompleter.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-api/src/main/java/org/apache/geronimo/gshell/command/CommandCompleter.java?rev=699409&r1=699408&r2=699409&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-api/src/main/java/org/apache/geronimo/gshell/command/CommandCompleter.java
(original)
+++ geronimo/gshell/trunk/gshell-api/src/main/java/org/apache/geronimo/gshell/command/CommandCompleter.java
Fri Sep 26 09:57:57 2008
@@ -28,9 +28,5 @@
  */
 public interface CommandCompleter
 {
-    //
-    // TODO: Not really sure this is what we want to do, but for now...
-    //
-    
     Completor createCompletor();
 }
\ No newline at end of file

Modified: geronimo/gshell/trunk/gshell-support/gshell-plexus/src/main/java/org/apache/geronimo/gshell/plexus/Slf4jLoggingManager.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-support/gshell-plexus/src/main/java/org/apache/geronimo/gshell/plexus/Slf4jLoggingManager.java?rev=699409&r1=699408&r2=699409&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-support/gshell-plexus/src/main/java/org/apache/geronimo/gshell/plexus/Slf4jLoggingManager.java
(original)
+++ geronimo/gshell/trunk/gshell-support/gshell-plexus/src/main/java/org/apache/geronimo/gshell/plexus/Slf4jLoggingManager.java
Fri Sep 26 09:57:57 2008
@@ -32,6 +32,7 @@
 public class Slf4jLoggingManager
     extends BaseLoggerManager
 {
+    //
     // FIXME: Probably need to change this to avoid picking up the BaseLoggerManager, just
implement everything ourselves
     //        Might be able to use AbstractLoggerManager
 

Modified: geronimo/gshell/trunk/gshell-support/gshell-spring/src/main/java/org/apache/geronimo/gshell/spring/LoggingProcessor.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-support/gshell-spring/src/main/java/org/apache/geronimo/gshell/spring/LoggingProcessor.java?rev=699409&r1=699408&r2=699409&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-support/gshell-spring/src/main/java/org/apache/geronimo/gshell/spring/LoggingProcessor.java
(original)
+++ geronimo/gshell/trunk/gshell-support/gshell-spring/src/main/java/org/apache/geronimo/gshell/spring/LoggingProcessor.java
Fri Sep 26 09:57:57 2008
@@ -384,10 +384,6 @@
             String beanName = replaceOverride.getMethodReplacerBeanName();
             builder.addAttribute(NAME_ATTRIBUTE, methodName);
             builder.addAttribute(REPLACER_ATTRIBUTE, beanName);
-
-            // TMP - so far it's not possible to obtain information about replacers....
-            // probably we need to use reflection based hack to obtain list of arg type
-            // identifiers
             builder.up();
         }
     }



Mime
View raw message