geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rickmcgu...@apache.org
Subject svn commit: r693530 - /geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/POP3Store.java
Date Tue, 09 Sep 2008 17:57:24 GMT
Author: rickmcguire
Date: Tue Sep  9 10:57:23 2008
New Revision: 693530

URL: http://svn.apache.org/viewvc?rev=693530&view=rev
Log:
GERONIMO-4290 pop3s: java.lang.IllegalArgumentException: hostname can't be null


Modified:
    geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/POP3Store.java

Modified: geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/POP3Store.java
URL: http://svn.apache.org/viewvc/geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/POP3Store.java?rev=693530&r1=693529&r2=693530&view=diff
==============================================================================
--- geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/POP3Store.java
(original)
+++ geronimo/javamail/trunk/geronimo-javamail_1.4/geronimo-javamail_1.4_provider/src/main/java/org/apache/geronimo/javamail/store/pop3/POP3Store.java
Tue Sep  9 10:57:23 2008
@@ -262,6 +262,12 @@
      * @see javax.mail.Service#isConnected()
      */
     public boolean isConnected() {
+        // the connect() method of the super class checks here first.  If the connected flag

+        // is off, then it's too early for use to try to get a connection and verify we still

+        // have a live one.  
+        if (!super.isConnected()) {
+            return false; 
+        }
         try {
             POP3Connection connection = getConnection(); 
             // a null connection likely means we had a failure establishing a 



Mime
View raw message