geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdil...@apache.org
Subject svn commit: r688012 - /geronimo/genesis/trunk/pom.xml
Date Fri, 22 Aug 2008 08:07:22 GMT
Author: jdillon
Date: Fri Aug 22 01:07:22 2008
New Revision: 688012

URL: http://svn.apache.org/viewvc?rev=688012&view=rev
Log:
Minor updates to validation muck

Modified:
    geronimo/genesis/trunk/pom.xml

Modified: geronimo/genesis/trunk/pom.xml
URL: http://svn.apache.org/viewvc/geronimo/genesis/trunk/pom.xml?rev=688012&r1=688011&r2=688012&view=diff
==============================================================================
--- geronimo/genesis/trunk/pom.xml (original)
+++ geronimo/genesis/trunk/pom.xml Fri Aug 22 01:07:22 2008
@@ -129,15 +129,18 @@
                         <artifactId>gmaven-plugin</artifactId>
                         <executions>
                             <execution>
+                                <id>check-passphrase</id>
                                 <phase>validate</phase>
                                 <goals>
                                     <goal>execute</goal>
                                 </goals>
                                 <configuration>
+                                    <!--
+                                    Make sure that we have a configured GPG passphrase.
+                                    -->
                                     <source>
-                                        // Make sure that we have a configured GPG passphrase
                                         def phrase = project.properties['gpg.passphrase']
-                                        if (phrase == null) {
+                                        if (phrase == null || phrase.trim() == '') {
                                             fail('Missing required property: gpg.passphrase')
                                         }
                                     </source>
@@ -192,19 +195,21 @@
                         <artifactId>gmaven-plugin</artifactId>
                         <executions>
                             <execution>
+                                <id>check-deploy-url</id>
                                 <phase>validate</phase>
                                 <goals>
                                     <goal>execute</goal>
                                 </goals>
                                 <configuration>
+                                    <!--
+                                    Make sure that we have a valid stage deployment URL configured,
+                                    and that the URL is parsable (ie. not a file reference,
which won't work
+                                    -->
                                     <source>
-                                        // Make sure that we have a valid stage deployment
URL configured
                                         def url = project.properties['stageDeployUrl']
                                         if (url == null || url.trim() == '') {
                                             fail('Missing required property: stageDeployUrl')
                                         }
-                                        
-                                        // Make sure its really a URL too
                                         try {
                                             new URL(url)
                                         }



Mime
View raw message