Return-Path: Delivered-To: apmail-geronimo-scm-archive@www.apache.org Received: (qmail 12621 invoked from network); 27 Jun 2008 19:22:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Jun 2008 19:22:13 -0000 Received: (qmail 83784 invoked by uid 500); 27 Jun 2008 19:22:14 -0000 Delivered-To: apmail-geronimo-scm-archive@geronimo.apache.org Received: (qmail 83740 invoked by uid 500); 27 Jun 2008 19:22:14 -0000 Mailing-List: contact scm-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list scm@geronimo.apache.org Received: (qmail 83731 invoked by uid 99); 27 Jun 2008 19:22:14 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jun 2008 12:22:14 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jun 2008 19:21:32 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 1C3EB2388A16; Fri, 27 Jun 2008 12:21:52 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r672362 - in /geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper: AmqJMSMessageHelper.java JMSMessageHelperFactory.java Date: Fri, 27 Jun 2008 19:21:51 -0000 To: scm@geronimo.apache.org From: dwoods@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080627192152.1C3EB2388A16@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: dwoods Date: Fri Jun 27 12:21:51 2008 New Revision: 672362 URL: http://svn.apache.org/viewvc?rev=672362&view=rev Log: GERONIMO-3983 upgrade applied patch to work with SLF4J Modified: geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/AmqJMSMessageHelper.java geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/JMSMessageHelperFactory.java Modified: geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/AmqJMSMessageHelper.java URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/AmqJMSMessageHelper.java?rev=672362&r1=672361&r2=672362&view=diff ============================================================================== --- geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/AmqJMSMessageHelper.java (original) +++ geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/AmqJMSMessageHelper.java Fri Jun 27 12:21:51 2008 @@ -127,7 +127,7 @@ stat.setQueueSize(proxy.getQueueSize()); } catch (Exception ex) { // ignoring the exception - log.error(ex); + log.error("Failed to get ActiveMQ stats", ex); } return stat; } @@ -144,7 +144,7 @@ BrokerServiceGBeanImpl ref = (BrokerServiceGBeanImpl) kernel.getGBean(BrokerServiceGBeanImpl.class); brokerName = ref.getBrokerName(); } catch (Exception e) { - log.equals(e); + log.error("Failed to get broker name", e); } return brokerName; } Modified: geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/JMSMessageHelperFactory.java URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/JMSMessageHelperFactory.java?rev=672362&r1=672361&r2=672362&view=diff ============================================================================== --- geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/JMSMessageHelperFactory.java (original) +++ geronimo/server/trunk/plugins/activemq/activemq-portlets/src/main/java/org/apache/geronimo/console/jmsmanager/helper/JMSMessageHelperFactory.java Fri Jun 27 12:21:51 2008 @@ -56,11 +56,11 @@ .forName("org.apache.geronimo.console.jmsmanager.helper.AmqJMSMessageHelper"); messageHelper = (JMSMessageHelper) class_.newInstance(); } catch (IllegalAccessException e) { - log.error(e); + log.error("Failed to load class", e); } catch (InstantiationException e) { - log.error(e); + log.error("Failed to load class", e); } catch (ClassNotFoundException e) { - log.error(e); + log.error("Failed to load class", e); } } if(messageHelper == null){