Return-Path: Delivered-To: apmail-geronimo-scm-archive@www.apache.org Received: (qmail 58338 invoked from network); 3 Jun 2008 08:18:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Jun 2008 08:18:47 -0000 Received: (qmail 993 invoked by uid 500); 3 Jun 2008 08:18:49 -0000 Delivered-To: apmail-geronimo-scm-archive@geronimo.apache.org Received: (qmail 938 invoked by uid 500); 3 Jun 2008 08:18:49 -0000 Mailing-List: contact scm-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list scm@geronimo.apache.org Received: (qmail 929 invoked by uid 99); 3 Jun 2008 08:18:49 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2008 01:18:49 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2008 08:18:08 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 94EDD2388A26; Tue, 3 Jun 2008 01:18:25 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r662689 - in /geronimo/gshell/trunk: gshell-buildsupport/gshell-maven-plugin/src/main/java/org/apache/geronimo/gshell/maven/gshell/CommandGleaner.java gshell-core/src/main/java/org/apache/geronimo/gshell/DefaultShell.java Date: Tue, 03 Jun 2008 08:18:25 -0000 To: scm@geronimo.apache.org From: jdillon@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080603081825.94EDD2388A26@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jdillon Date: Tue Jun 3 01:18:25 2008 New Revision: 662689 URL: http://svn.apache.org/viewvc?rev=662689&view=rev Log: Tidy up Modified: geronimo/gshell/trunk/gshell-buildsupport/gshell-maven-plugin/src/main/java/org/apache/geronimo/gshell/maven/gshell/CommandGleaner.java geronimo/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/DefaultShell.java Modified: geronimo/gshell/trunk/gshell-buildsupport/gshell-maven-plugin/src/main/java/org/apache/geronimo/gshell/maven/gshell/CommandGleaner.java URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-buildsupport/gshell-maven-plugin/src/main/java/org/apache/geronimo/gshell/maven/gshell/CommandGleaner.java?rev=662689&r1=662688&r2=662689&view=diff ============================================================================== --- geronimo/gshell/trunk/gshell-buildsupport/gshell-maven-plugin/src/main/java/org/apache/geronimo/gshell/maven/gshell/CommandGleaner.java (original) +++ geronimo/gshell/trunk/gshell-buildsupport/gshell-maven-plugin/src/main/java/org/apache/geronimo/gshell/maven/gshell/CommandGleaner.java Tue Jun 3 01:18:25 2008 @@ -99,10 +99,6 @@ Command command = new Command(); - // - // TODO: Set the source... - // - command.setId(anno.id()); command.setDescription(filterEmptyAsNull(anno.description())); Modified: geronimo/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/DefaultShell.java URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/DefaultShell.java?rev=662689&r1=662688&r2=662689&view=diff ============================================================================== --- geronimo/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/DefaultShell.java (original) +++ geronimo/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/DefaultShell.java Tue Jun 3 01:18:25 2008 @@ -114,13 +114,6 @@ this.env = context.getEnvironment(); this.branding = context.getApplication().getBranding(); - // - // FIXME: This won't work as desired, as this shell instance is not yet registered, so if a profile - // tries to run something that needs the shell instance... well, loopsvile. - // - // This could be a warning sign that some of this class needs to be split up into smaller bits... - // - try { loadProfileScripts(); }