Return-Path: Delivered-To: apmail-geronimo-scm-archive@www.apache.org Received: (qmail 30554 invoked from network); 30 May 2008 12:38:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 30 May 2008 12:38:43 -0000 Received: (qmail 74856 invoked by uid 500); 30 May 2008 12:38:45 -0000 Delivered-To: apmail-geronimo-scm-archive@geronimo.apache.org Received: (qmail 74795 invoked by uid 500); 30 May 2008 12:38:45 -0000 Mailing-List: contact scm-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list scm@geronimo.apache.org Received: (qmail 74786 invoked by uid 99); 30 May 2008 12:38:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 May 2008 05:38:45 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 May 2008 12:37:58 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 5080E23889F7; Fri, 30 May 2008 05:38:20 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r661690 - /geronimo/gshell/trunk/gshell-support/gshell-artifact/src/main/java/org/apache/geronimo/gshell/artifact/DefaultArtifactManager.java Date: Fri, 30 May 2008 12:38:20 -0000 To: scm@geronimo.apache.org From: jdillon@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080530123820.5080E23889F7@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jdillon Date: Fri May 30 05:38:19 2008 New Revision: 661690 URL: http://svn.apache.org/viewvc?rev=661690&view=rev Log: Throw exceptions when resolve() fails Modified: geronimo/gshell/trunk/gshell-support/gshell-artifact/src/main/java/org/apache/geronimo/gshell/artifact/DefaultArtifactManager.java Modified: geronimo/gshell/trunk/gshell-support/gshell-artifact/src/main/java/org/apache/geronimo/gshell/artifact/DefaultArtifactManager.java URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-support/gshell-artifact/src/main/java/org/apache/geronimo/gshell/artifact/DefaultArtifactManager.java?rev=661690&r1=661689&r2=661690&view=diff ============================================================================== --- geronimo/gshell/trunk/gshell-support/gshell-artifact/src/main/java/org/apache/geronimo/gshell/artifact/DefaultArtifactManager.java (original) +++ geronimo/gshell/trunk/gshell-support/gshell-artifact/src/main/java/org/apache/geronimo/gshell/artifact/DefaultArtifactManager.java Fri May 30 05:38:19 2008 @@ -111,7 +111,13 @@ log.debug("Validating result: {}", result); - if (/* TODO: detect failure */ false) { + if (result.hasErrorArtifactExceptions() || + result.hasCircularDependencyExceptions() || + result.hasMetadataResolutionExceptions() || + result.hasVersionRangeViolations() || + !result.getMissingArtifacts().isEmpty()) + { + // Puke throw new ResolutionException(request, result); }