geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdil...@apache.org
Subject svn commit: r659515 - in /geronimo/gshell/trunk: gshell-bootstrap/src/main/java/org/apache/geronimo/gshell/bootstrap/Launcher.java gshell-cli/src/main/java/org/apache/geronimo/gshell/cli/Main.java
Date Fri, 23 May 2008 12:24:25 GMT
Author: jdillon
Date: Fri May 23 05:24:24 2008
New Revision: 659515

URL: http://svn.apache.org/viewvc?rev=659515&view=rev
Log:
Some comments

Modified:
    geronimo/gshell/trunk/gshell-bootstrap/src/main/java/org/apache/geronimo/gshell/bootstrap/Launcher.java
    geronimo/gshell/trunk/gshell-cli/src/main/java/org/apache/geronimo/gshell/cli/Main.java

Modified: geronimo/gshell/trunk/gshell-bootstrap/src/main/java/org/apache/geronimo/gshell/bootstrap/Launcher.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-bootstrap/src/main/java/org/apache/geronimo/gshell/bootstrap/Launcher.java?rev=659515&r1=659514&r2=659515&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-bootstrap/src/main/java/org/apache/geronimo/gshell/bootstrap/Launcher.java
(original)
+++ geronimo/gshell/trunk/gshell-bootstrap/src/main/java/org/apache/geronimo/gshell/bootstrap/Launcher.java
Fri May 23 05:24:24 2008
@@ -49,6 +49,11 @@
         homeDir = getHomeDir();
         setProperty("gshell.home", homeDir.getCanonicalPath());
 
+        //
+        // FIXME: Should load the classworlds.conf from a resource, and hide it in the bootstrap
jar, as folks should not
+        //        alter it anymore...
+        //
+        
         File classworldsConf = getClassworldsConf();
         setProperty("classworlds.conf", classworldsConf.getCanonicalPath());
 

Modified: geronimo/gshell/trunk/gshell-cli/src/main/java/org/apache/geronimo/gshell/cli/Main.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-cli/src/main/java/org/apache/geronimo/gshell/cli/Main.java?rev=659515&r1=659514&r2=659515&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-cli/src/main/java/org/apache/geronimo/gshell/cli/Main.java
(original)
+++ geronimo/gshell/trunk/gshell-cli/src/main/java/org/apache/geronimo/gshell/cli/Main.java
Fri May 23 05:24:24 2008
@@ -255,6 +255,9 @@
             ApplicationMarshaller applicationMarshaller = new ApplicationMarshaller();
             URL applicationUrl = getClass().getClassLoader().getResource("application.xml");
             Application application = applicationMarshaller.unmarshal(applicationUrl);
+
+            // FIXME: Need to root the local repo's directory to user.home if its relative
for now util ${user.home} expansion is supported
+             
             builder.setApplication(application);
 
             GShell gshell = builder.build();



Mime
View raw message