geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ga...@apache.org
Subject svn commit: r637260 - /geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/GBeanOverride.java
Date Fri, 14 Mar 2008 20:54:45 GMT
Author: gawor
Date: Fri Mar 14 13:54:43 2008
New Revision: 637260

URL: http://svn.apache.org/viewvc?rev=637260&view=rev
Log:
throw IllegalStateException instead of returning null if PropertyEditor cannot be loaded/found
(GERONIMO-3814)

Modified:
    geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/GBeanOverride.java

Modified: geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/GBeanOverride.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/GBeanOverride.java?rev=637260&r1=637259&r2=637260&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/GBeanOverride.java
(original)
+++ geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/GBeanOverride.java
Fri Mar 14 13:54:43 2008
@@ -398,11 +398,10 @@
             try {
                 editor = PropertyEditors.findEditor(attribute.getType(), classLoader);
             } catch (ClassNotFoundException e) {
-                log.error("Unable to load attribute type " + attribute.getType());
-                return null;
-            }
+                throw new IllegalStateException("Unable to load property editor for attribute
type: " + attribute.getType());
+            }            
             if (editor == null) {
-                log.debug("Unable to parse attribute of type " + attribute.getType() + ";
no editor found");
+                throw new IllegalStateException("Unable to parse attribute of type " + attribute.getType()
+ "; no editor found");
             }
             return editor;
         } else {



Mime
View raw message