geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vamsic...@apache.org
Subject svn commit: r591903 - in /geronimo/server: branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/ trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/
Date Mon, 05 Nov 2007 07:41:57 GMT
Author: vamsic007
Date: Sun Nov  4 23:41:55 2007
New Revision: 591903

URL: http://svn.apache.org/viewvc?rev=591903&view=rev
Log:
Make supportedOptions an unmodifiableList to prevent accidental modification.

Modified:
    geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificateChainLoginModule.java
    geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificatePropertiesFileLoginModule.java
    geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
    geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/PropertiesFileLoginModule.java
    geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/SQLLoginModule.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificateChainLoginModule.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificatePropertiesFileLoginModule.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/PropertiesFileLoginModule.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/SQLLoginModule.java

Modified: geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificateChainLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificateChainLoginModule.java?rev=591903&r1=591902&r2=591903&view=diff
==============================================================================
--- geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificateChainLoginModule.java
(original)
+++ geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificateChainLoginModule.java
Sun Nov  4 23:41:55 2007
@@ -56,7 +56,9 @@
 public class CertificateChainLoginModule implements LoginModule {
     private static Log log = LogFactory.getLog(CertificateChainLoginModule.class);
 
-    public final static List<String> supportedOptions = Arrays.asList();
+    // Note: If this LoginModule supports any options, the Collections.EMPTY_LIST in the
following should be
+    // replaced with the list of supported options for e.g. Arrays.asList(option1, option2,
...) etc.
+    public final static List<String> supportedOptions = Collections.unmodifiableList(Collections.EMPTY_LIST);
     private Subject subject;
     private CallbackHandler handler;
     private X500Principal principal;

Modified: geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificatePropertiesFileLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificatePropertiesFileLoginModule.java?rev=591903&r1=591902&r2=591903&view=diff
==============================================================================
--- geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificatePropertiesFileLoginModule.java
(original)
+++ geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificatePropertiesFileLoginModule.java
Sun Nov  4 23:41:55 2007
@@ -72,7 +72,7 @@
     private static Log log = LogFactory.getLog(CertificatePropertiesFileLoginModule.class);
     public final static String USERS_URI = "usersURI";
     public final static String GROUPS_URI = "groupsURI";
-    public final static List<String> supportedOptions = Arrays.asList(USERS_URI, GROUPS_URI);
+    public final static List<String> supportedOptions = Collections.unmodifiableList(Arrays.asList(USERS_URI,
GROUPS_URI));
             
     private final Map users = new HashMap();
     final Map groups = new HashMap();

Modified: geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java?rev=591903&r1=591902&r2=591903&view=diff
==============================================================================
--- geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
(original)
+++ geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
Sun Nov  4 23:41:55 2007
@@ -87,10 +87,10 @@
     private static final String ROLE_SEARCH_MATCHING = "roleSearchMatching";
     private static final String ROLE_SEARCH_SUBTREE = "roleSearchSubtree";
     private static final String USER_ROLE_NAME = "userRoleName";
-    public final static List<String> supportedOptions = Arrays.asList(INITIAL_CONTEXT_FACTORY,
CONNECTION_URL,
+    public final static List<String> supportedOptions = Collections.unmodifiableList(Arrays.asList(INITIAL_CONTEXT_FACTORY,
CONNECTION_URL,
             CONNECTION_USERNAME, CONNECTION_PASSWORD, CONNECTION_PROTOCOL, AUTHENTICATION,
USER_BASE,
             USER_SEARCH_MATCHING, USER_SEARCH_SUBTREE, ROLE_BASE, ROLE_NAME, ROLE_SEARCH_MATCHING,
ROLE_SEARCH_SUBTREE,
-            USER_ROLE_NAME);
+            USER_ROLE_NAME));
 
     private String initialContextFactory;
     private String connectionURL;

Modified: geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/PropertiesFileLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/PropertiesFileLoginModule.java?rev=591903&r1=591902&r2=591903&view=diff
==============================================================================
--- geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/PropertiesFileLoginModule.java
(original)
+++ geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/PropertiesFileLoginModule.java
Sun Nov  4 23:41:55 2007
@@ -70,7 +70,7 @@
     public final static String GROUPS_URI = "groupsURI";
     public final static String DIGEST = "digest";
     public final static String ENCODING = "encoding";
-    public final static List<String> supportedOptions = Arrays.asList(USERS_URI, GROUPS_URI,
DIGEST, ENCODING);
+    public final static List<String> supportedOptions = Collections.unmodifiableList(Arrays.asList(USERS_URI,
GROUPS_URI, DIGEST, ENCODING));
 
     private static Log log = LogFactory.getLog(PropertiesFileLoginModule.class);
     final Properties users = new Properties();

Modified: geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/SQLLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/SQLLoginModule.java?rev=591903&r1=591902&r2=591903&view=diff
==============================================================================
--- geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/SQLLoginModule.java
(original)
+++ geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/SQLLoginModule.java
Sun Nov  4 23:41:55 2007
@@ -96,8 +96,8 @@
     public final static String DATABASE_POOL_APP_NAME = "dataSourceApplication";
     public final static String DIGEST = "digest";
     public final static String ENCODING = "encoding";
-    public final static List<String> supportedOptions = Arrays.asList(USER_SELECT,
GROUP_SELECT, CONNECTION_URL,
-            USER, PASSWORD, DRIVER, DATABASE_POOL_NAME, DATABASE_POOL_APP_NAME, DIGEST, ENCODING);
+    public final static List<String> supportedOptions = Collections.unmodifiableList(Arrays.asList(USER_SELECT,
GROUP_SELECT, CONNECTION_URL,
+            USER, PASSWORD, DRIVER, DATABASE_POOL_NAME, DATABASE_POOL_APP_NAME, DIGEST, ENCODING));
 
     private String connectionURL;
     private Properties properties;

Modified: geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificateChainLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificateChainLoginModule.java?rev=591903&r1=591902&r2=591903&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificateChainLoginModule.java
(original)
+++ geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificateChainLoginModule.java
Sun Nov  4 23:41:55 2007
@@ -56,7 +56,9 @@
 public class CertificateChainLoginModule implements LoginModule {
     private static Log log = LogFactory.getLog(CertificateChainLoginModule.class);
 
-    public final static List<String> supportedOptions = Arrays.asList();
+    // Note: If this LoginModule supports any options, the Collections.EMPTY_LIST in the
following should be
+    // replaced with the list of supported options for e.g. Arrays.asList(option1, option2,
...) etc.
+    public final static List<String> supportedOptions = Collections.unmodifiableList(Collections.EMPTY_LIST);
     private Subject subject;
     private CallbackHandler handler;
     private X500Principal principal;

Modified: geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificatePropertiesFileLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificatePropertiesFileLoginModule.java?rev=591903&r1=591902&r2=591903&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificatePropertiesFileLoginModule.java
(original)
+++ geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/CertificatePropertiesFileLoginModule.java
Sun Nov  4 23:41:55 2007
@@ -72,7 +72,7 @@
     private static Log log = LogFactory.getLog(CertificatePropertiesFileLoginModule.class);
     public final static String USERS_URI = "usersURI";
     public final static String GROUPS_URI = "groupsURI";
-    public final static List<String> supportedOptions = Arrays.asList(USERS_URI, GROUPS_URI);
+    public final static List<String> supportedOptions = Collections.unmodifiableList(Arrays.asList(USERS_URI,
GROUPS_URI));
             
     private final Map users = new HashMap();
     final Map groups = new HashMap();

Modified: geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java?rev=591903&r1=591902&r2=591903&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
(original)
+++ geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
Sun Nov  4 23:41:55 2007
@@ -87,10 +87,10 @@
     private static final String ROLE_SEARCH_MATCHING = "roleSearchMatching";
     private static final String ROLE_SEARCH_SUBTREE = "roleSearchSubtree";
     private static final String USER_ROLE_NAME = "userRoleName";
-    public final static List<String> supportedOptions = Arrays.asList(INITIAL_CONTEXT_FACTORY,
CONNECTION_URL,
+    public final static List<String> supportedOptions = Collections.unmodifiableList(Arrays.asList(INITIAL_CONTEXT_FACTORY,
CONNECTION_URL,
             CONNECTION_USERNAME, CONNECTION_PASSWORD, CONNECTION_PROTOCOL, AUTHENTICATION,
USER_BASE,
             USER_SEARCH_MATCHING, USER_SEARCH_SUBTREE, ROLE_BASE, ROLE_NAME, ROLE_SEARCH_MATCHING,
ROLE_SEARCH_SUBTREE,
-            USER_ROLE_NAME);
+            USER_ROLE_NAME));
 
     private String initialContextFactory;
     private String connectionURL;

Modified: geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/PropertiesFileLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/PropertiesFileLoginModule.java?rev=591903&r1=591902&r2=591903&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/PropertiesFileLoginModule.java
(original)
+++ geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/PropertiesFileLoginModule.java
Sun Nov  4 23:41:55 2007
@@ -70,7 +70,7 @@
     public final static String GROUPS_URI = "groupsURI";
     public final static String DIGEST = "digest";
     public final static String ENCODING = "encoding";
-    public final static List<String> supportedOptions = Arrays.asList(USERS_URI, GROUPS_URI,
DIGEST, ENCODING);
+    public final static List<String> supportedOptions = Collections.unmodifiableList(Arrays.asList(USERS_URI,
GROUPS_URI, DIGEST, ENCODING));
 
     private static Log log = LogFactory.getLog(PropertiesFileLoginModule.class);
     final Properties users = new Properties();

Modified: geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/SQLLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/SQLLoginModule.java?rev=591903&r1=591902&r2=591903&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/SQLLoginModule.java
(original)
+++ geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/SQLLoginModule.java
Sun Nov  4 23:41:55 2007
@@ -96,8 +96,8 @@
     public final static String DATABASE_POOL_APP_NAME = "dataSourceApplication";
     public final static String DIGEST = "digest";
     public final static String ENCODING = "encoding";
-    public final static List<String> supportedOptions = Arrays.asList(USER_SELECT,
GROUP_SELECT, CONNECTION_URL,
-            USER, PASSWORD, DRIVER, DATABASE_POOL_NAME, DATABASE_POOL_APP_NAME, DIGEST, ENCODING);
+    public final static List<String> supportedOptions = Collections.unmodifiableList(Arrays.asList(USER_SELECT,
GROUP_SELECT, CONNECTION_URL,
+            USER, PASSWORD, DRIVER, DATABASE_POOL_NAME, DATABASE_POOL_APP_NAME, DIGEST, ENCODING));
 
     private String connectionURL;
     private Properties properties;



Mime
View raw message