geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vamsic...@apache.org
Subject svn commit: r590833 - in /geronimo/server: branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/ trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/ trunk/mo...
Date Wed, 31 Oct 2007 21:13:58 GMT
Author: vamsic007
Date: Wed Oct 31 14:13:57 2007
New Revision: 590833

URL: http://svn.apache.org/viewvc?rev=590833&view=rev
Log:
Remove redundant code. The catch block handles this part.

Modified:
    geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
    geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
    geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java

Modified: geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java?rev=590833&r1=590832&r2=590833&view=diff
==============================================================================
--- geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
(original)
+++ geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
Wed Oct 31 14:13:57 2007
@@ -177,10 +177,6 @@
         try {
             boolean result = authenticate(cbUsername, cbPassword);
             if (!result) {
-                // Clear out the private state
-                cbUsername = null;
-                cbPassword = null;
-                groups.retainAll(Collections.EMPTY_SET);
                 throw new FailedLoginException();
             }
         } catch (LoginException e) {

Modified: geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java?rev=590833&r1=590832&r2=590833&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
(original)
+++ geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
Wed Oct 31 14:13:57 2007
@@ -177,10 +177,6 @@
         try {
             boolean result = authenticate(cbUsername, cbPassword);
             if (!result) {
-                // Clear out the private state
-                cbUsername = null;
-                cbPassword = null;
-                groups.retainAll(Collections.EMPTY_SET);
                 throw new FailedLoginException();
             }
         } catch (LoginException e) {

Modified: geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java?rev=590833&r1=590832&r2=590833&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
(original)
+++ geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
Wed Oct 31 14:13:57 2007
@@ -177,10 +177,6 @@
         try {
             boolean result = authenticate(cbUsername, cbPassword);
             if (!result) {
-                // Clear out the private state
-                cbUsername = null;
-                cbPassword = null;
-                groups.retainAll(Collections.EMPTY_SET);
                 throw new FailedLoginException();
             }
         } catch (LoginException e) {



Mime
View raw message