geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vamsic...@apache.org
Subject svn commit: r582984 - in /geronimo/server: branches/2.0.2/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/ branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/ trunk/modules/geronimo-security/src...
Date Mon, 08 Oct 2007 21:38:45 GMT
Author: vamsic007
Date: Mon Oct  8 14:38:44 2007
New Revision: 582984

URL: http://svn.apache.org/viewvc?rev=582984&view=rev
Log:
Throws NPE when the id does not exist.  Supposed to return null.

Modified:
    geronimo/server/branches/2.0.2/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java
    geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java
    geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java

Modified: geronimo/server/branches/2.0.2/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0.2/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java?rev=582984&r1=582983&r2=582984&view=diff
==============================================================================
--- geronimo/server/branches/2.0.2/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java
(original)
+++ geronimo/server/branches/2.0.2/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java
Mon Oct  8 14:38:44 2007
@@ -223,6 +223,10 @@
      */
     public BigInteger getSerialNumberForRequest(String id) {
         BigInteger sNo = null;
+        if(requestStatus.getProperty(id) == null) {
+            // No such request
+            return null;
+        }
         try {
             sNo = new BigInteger(requestStatus.getProperty(id));
         } catch(NumberFormatException e) {

Modified: geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java?rev=582984&r1=582983&r2=582984&view=diff
==============================================================================
--- geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java
(original)
+++ geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java
Mon Oct  8 14:38:44 2007
@@ -223,6 +223,10 @@
      */
     public BigInteger getSerialNumberForRequest(String id) {
         BigInteger sNo = null;
+        if(requestStatus.getProperty(id) == null) {
+            // No such request
+            return null;
+        }
         try {
             sNo = new BigInteger(requestStatus.getProperty(id));
         } catch(NumberFormatException e) {

Modified: geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java?rev=582984&r1=582983&r2=582984&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java
(original)
+++ geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/ca/FileCertificateRequestStore.java
Mon Oct  8 14:38:44 2007
@@ -223,6 +223,10 @@
      */
     public BigInteger getSerialNumberForRequest(String id) {
         BigInteger sNo = null;
+        if(requestStatus.getProperty(id) == null) {
+            // No such request
+            return null;
+        }
         try {
             sNo = new BigInteger(requestStatus.getProperty(id));
         } catch(NumberFormatException e) {



Mime
View raw message