Return-Path: Delivered-To: apmail-geronimo-scm-archive@www.apache.org Received: (qmail 64607 invoked from network); 18 Sep 2007 01:56:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Sep 2007 01:56:13 -0000 Received: (qmail 66126 invoked by uid 500); 18 Sep 2007 01:56:04 -0000 Delivered-To: apmail-geronimo-scm-archive@geronimo.apache.org Received: (qmail 66091 invoked by uid 500); 18 Sep 2007 01:56:04 -0000 Mailing-List: contact scm-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list scm@geronimo.apache.org Received: (qmail 66080 invoked by uid 99); 18 Sep 2007 01:56:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Sep 2007 18:56:04 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Sep 2007 01:56:12 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id DA1B01A9832; Mon, 17 Sep 2007 18:55:51 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r576653 - /geronimo/sandbox/gshell/trunk/gshell-remote/gshell-remote-common/src/main/java/org/apache/geronimo/gshell/remote/message/MessageResponseInspector.java Date: Tue, 18 Sep 2007 01:55:51 -0000 To: scm@geronimo.apache.org From: jdillon@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20070918015551.DA1B01A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jdillon Date: Mon Sep 17 18:55:51 2007 New Revision: 576653 URL: http://svn.apache.org/viewvc?rev=576653&view=rev Log: Syncrhonize the set not the inspector methods Modified: geronimo/sandbox/gshell/trunk/gshell-remote/gshell-remote-common/src/main/java/org/apache/geronimo/gshell/remote/message/MessageResponseInspector.java Modified: geronimo/sandbox/gshell/trunk/gshell-remote/gshell-remote-common/src/main/java/org/apache/geronimo/gshell/remote/message/MessageResponseInspector.java URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/gshell-remote/gshell-remote-common/src/main/java/org/apache/geronimo/gshell/remote/message/MessageResponseInspector.java?rev=576653&r1=576652&r2=576653&view=diff ============================================================================== --- geronimo/sandbox/gshell/trunk/gshell-remote/gshell-remote-common/src/main/java/org/apache/geronimo/gshell/remote/message/MessageResponseInspector.java (original) +++ geronimo/sandbox/gshell/trunk/gshell-remote/gshell-remote-common/src/main/java/org/apache/geronimo/gshell/remote/message/MessageResponseInspector.java Mon Sep 17 18:55:51 2007 @@ -19,6 +19,7 @@ package org.apache.geronimo.gshell.remote.message; +import java.util.Collections; import java.util.HashSet; import java.util.Set; import java.util.UUID; @@ -39,9 +40,9 @@ { private Logger log = LoggerFactory.getLogger(getClass()); - private Set registeredIds = new HashSet(); + private Set registeredIds = Collections.synchronizedSet(new HashSet()); - public synchronized void register(final Request req) { + public void register(final Request req) { assert req != null; UUID id = (UUID) req.getId(); @@ -56,7 +57,7 @@ } } - public synchronized void deregister(final Request req) { + public void deregister(final Request req) { assert req != null; UUID id = (UUID) req.getId(); @@ -73,7 +74,7 @@ // ResponseInspector // - public synchronized Object getRequestId(final Object message) { + public Object getRequestId(final Object message) { if (message instanceof Message) { UUID id = ((Message)message).getCorrelationId();